Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Long Quote Block in LiveResource #659

Merged
merged 22 commits into from
Nov 14, 2024
Merged

Refactor Long Quote Block in LiveResource #659

merged 22 commits into from
Nov 14, 2024

Commits on Nov 8, 2024

  1. move handle_event from quote block to top level module

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5a40644 View commit details
    Browse the repository at this point in the history

  2. move handle_info from quote block to top level module

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0f35706 View commit details
    Browse the repository at this point in the history

  3. move mount from quote block to top level module

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    68d9872 View commit details
    Browse the repository at this point in the history

  4. move handle_params from quote block to top level module

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b1af85c View commit details
    Browse the repository at this point in the history

  5. remove unused parameter

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2a43e79 View commit details
    Browse the repository at this point in the history

  6. shorten function calls

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    799e285 View commit details
    Browse the repository at this point in the history

  7. simplify active filters function

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2aad9ba View commit details
    Browse the repository at this point in the history

  8. remove obsolete Backpex.LiveResource.can?/4 helper

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9bdd735 View commit details
    Browse the repository at this point in the history

  9. move primary_value from quote block to top level module

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fd18140 View commit details
    Browse the repository at this point in the history

  10. fix live updates for non-id primary keys

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    dc051d2 View commit details
    Browse the repository at this point in the history

  11. fix function call

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a474210 View commit details
    Browse the repository at this point in the history

  12. move render from quote block to top level module

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2d1ee20 View commit details
    Browse the repository at this point in the history

  13. remove Backpex.LiveResource.schema/0 function

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    709bff8 View commit details
    Browse the repository at this point in the history

  14. change some internal functions to private

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f7f124b View commit details
    Browse the repository at this point in the history

  15. Merge branch 'develop' into feature/refactor-liveresource-using

    @pehbehbeh
    pehbehbeh committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    545e496 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Florian Arens <[email protected]>
    @pehbehbeh @Flo0807
    pehbehbeh and Flo0807 authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    35f7599 View commit details
    Browse the repository at this point in the history

  2. use correct live_resource of association

    @pehbehbeh
    pehbehbeh committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d078869 View commit details
    Browse the repository at this point in the history

  3. remove module attribute for empty_filter_key

    @pehbehbeh
    pehbehbeh committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    778d592 View commit details
    Browse the repository at this point in the history

  4. add upgrade guide note for changed LiveResource functions

    @pehbehbeh
    pehbehbeh committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d6c8c1e View commit details
    Browse the repository at this point in the history

  5. remove module attribute for permitted_order_directions

    @pehbehbeh
    pehbehbeh committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1895d00 View commit details
    Browse the repository at this point in the history

  6. fix order_options_by_params doctest

    @pehbehbeh
    pehbehbeh committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    05049b8 View commit details
    Browse the repository at this point in the history

  7. please credo

    @pehbehbeh
    pehbehbeh committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    85a1f3d View commit details
    Browse the repository at this point in the history