-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[s3inbox] run healthchecks in main process #1025
Conversation
You're on the right path. |
to make sure all reasons for panic are logged
0ee0e2b
to
b123dbb
Compare
b123dbb
to
9679f79
Compare
Thanks for the quick review @jbygdell! Fixes are pushed. |
904ee5e
to
98321ef
Compare
e5c12dd
to
ad0a562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left a minor comment regarding the use of GET request and HEAD request for obtaining the HTTP code. But I approve it anyway 😄
Related issue(s) and PR(s)
This PR addresses #992.
Description
/health
endpoint is put on the same port as s3inbox (ie. is run on the server started ins3inbox.go
).HEAD
request to s3inbox will return the health status.CheckHealth
attempts to restore it./ready
and/live
endpoints are removed/healthz
enpoint (provided by the charts) is removedIf this is to be continue: create issues for updating charts etc reflect this change.
How to test
curl 'localhost:18000' -H 'Authorization: Bearer $token' -I
curl 'localhost:18000/health' -H 'Authorization: Bearer $token'