Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s3inbox] run healthchecks in main process #1025

Merged
merged 11 commits into from
Sep 12, 2024
Merged

[s3inbox] run healthchecks in main process #1025

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dd3a5d4
[s3inbox] run healthchecks in main thread, on same port
MalinAhlberg Sep 2, 2024
abe456c
tests: update s3inbox health tests
MalinAhlberg Sep 10, 2024
908450c
Use gorilla mux for head requests
MalinAhlberg Sep 9, 2024
93ad7bc
[s3inbox] log fatal errors
MalinAhlberg Sep 9, 2024
9679f79
Add integration tests
MalinAhlberg Sep 9, 2024
41bad3e
tests: remove token from health check
MalinAhlberg Sep 10, 2024
98321ef
refactor: use path to join strings, minor cleanups
MalinAhlberg Sep 10, 2024
ad0a562
fix parsing of and tests for s3 url
MalinAhlberg Sep 10, 2024
4daa4a8
[charts] update s3inbox's health check
MalinAhlberg Sep 11, 2024
3446820
tests: use get request for /health
MalinAhlberg Sep 11, 2024
65e71af
[charts] remove /healthz endpoint of s3inbox
MalinAhlberg Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/integration/tests/sda/09_healthchecks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if [ "$response" != "200" ]; then
exit 1
fi

response="$(curl -s -k -LI "http://s3inbox:8000/health" -o /dev/null -w "%{http_code}\n")"
response="$(curl -s -k -L "http://s3inbox:8000/health" -o /dev/null -w "%{http_code}\n")"
MalinAhlberg marked this conversation as resolved.
Show resolved Hide resolved
if [ "$response" != "200" ]; then
echo "Bad health response from /health, expected 200 got: $response"
exit 1
Expand Down