-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: How to run SDA stack #1162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 282896d can be removed in it's entirety since the --remove-orphans
in the compose down
command will do just that.
The problem is on Linux Ubuntu, the exited container for the integration test is not removed by |
How come then that I haven't seen this issue on Ubuntu for the past several years. |
No idea. I have problems on two of the VMs with Ubuntu 22.04, but another VM with Ubuntu 18.04 actually works. I will remove the commit but keep it only locally. |
05953bf
to
473be23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work to document all this @nanjiangshu 👏 !
I have added some comments/suggestions. I also wonder if it would make more sense to keep most of this in the GETTINGSTARTED
and link it from the README
? Since it's so detailed (which is very good but maybe a bit too much for the readme). And in that case also update the help
text of the Makefile.
That's a good point. However, as I discussed with @jbygdell and @viklund in one of the standups, we believe that a shorter README might lead people to overlook these instructions. Currently, the text isn't too long, but I agree that if it grows in the future, we should consider making it more structured and moving the detailed instructions elsewhere. We can probably create a refactoring issue for the development instructions and move some of the instructions to https://github.com/neicnordic/sensitive-data-archive/blob/feature/manual-go-run/DEVELOPMENT.md |
27428b2
to
3e45fc7
Compare
441cc5f
30c7ed1
to
96adbd3
Compare
The base branch was changed.
e39e066
to
30c7ed1
Compare
Co-authored-by: Joakim Bygdell <[email protected]>
8deb24e
to
06d83ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny thing.
Co-authored-by: Joakim Bygdell <[email protected]>
Hi @jbygdell and @MalinAhlberg , committed some tiny formatting changes to the docs and the PR needs your re-approval. Thank you. |
Related issue(s) and PR(s)
This PR closes #1153
Changes made