Seekable S3 support, second take #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pontus
force-pushed
the
feature/seekable_s3_v2
branch
from
2380e41 to
dd4ed6f
Compare
MalinAhlberg
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
I tested this merged with #820 , which worked well! The merging does require some manual work, though, but I don't think there's anything that could be fixed in this PR.
nanjiangshu
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Looks great! I also tested with the PR #820 and htsget-rust and it works well.
jbygdell
approved these changes
Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #703. It's roughly the same code, but seekable (new) functionality is now in different files from the old things for the storage implementation.