Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #512
Tag format:
{forwarder-name}_c_{connID}
We try to dump interfaces here to restore them in forwarder.
dump
function which, by tag, determines whether this is "our" interface or not.Elements with a dump implementation here:
-
tap
-
af_packet
-
memif
-
vxlan
-
L3xc
Additional info
veth pair (af_packet):
We set aliases for kernel veth-pair - https://github.com/networkservicemesh/sdk-vpp/blob/main/pkg/networkservice/mechanisms/kernel/kernelvethpair/common.go#L73.
As I understand, alias format must be the same as tag format. So, probably it's better to add a new chain element, that will add aliases for linux interfaces.
And the veth-pair dump must be through
netlink
(seekernelvethpair/common.go
in this PR)Open question
Perhaps the order of deletion is important to us. With this approach, we cannot guarantee this.
Probably we should omit deletion after the timeout and use only restore?
Deletion will be if the client calls
Close
Signed-off-by: Artem Glazychev [email protected]