Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert make to python #6

Closed
wants to merge 14 commits into from
Closed

Convert make to python #6

wants to merge 14 commits into from

Conversation

atemate
Copy link
Contributor

@atemate atemate commented Sep 5, 2019

Pros:

  1. python script is cross-platform (make won't work on windows)
  2. python script is much more readable
  3. python script gives more control

@astaff astaff added the platform label Sep 5, 2019
@atemate atemate changed the title [WIP] Convert make to python Convert make to python Sep 6, 2019
@atemate atemate marked this pull request as ready for review September 6, 2019 15:53
@asvetlov
Copy link

asvetlov commented Sep 6, 2019

I suggest taking a look on http://www.pyinvoke.org
I used this tool, works like a charm.
Benefits:

  • Provides battle-tested, documented and well-supported instrument instead of home-made solution (which may be good as well but requires more work on edge cases etc, you know what I mean).
  • out-of-the-box supports command parameters and options
  • supports code completion out-of-the-box.
  • I really love context.cd() and context.run() helpers, they are very handly.
    Disadvantages:
  • make is much more common tool (not sure if data scientists know it well though)
  • you have to pip install invoke before usage

@atemate
Copy link
Contributor Author

atemate commented Sep 9, 2019

@asvetlov thank you for your proposal! please see the alternative PR that uses pyinvoke: #9

@atemate
Copy link
Contributor Author

atemate commented Sep 9, 2019

Closing as for now we decided to stick with Makefile

@atemate atemate closed this Sep 9, 2019
@atemate atemate deleted the ay/make-to-python branch December 19, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants