-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maybe] Convert make to python using pyinvoke #9
Conversation
In real life, you quickly start wanting to use additional libraries anyway. Even
I consider this as a benefit, not an objection :)
I cannot buy it.
The warning is not shown by default. Would be nice to fix it eventually but it is not a show stopper.
Not sure if annotations matter in |
from setuptools import find_packages, setup | ||
|
||
|
||
setup( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this setup.py
file?
Do you want to publish it on pypi, import by python code, support versioning etc.?
From my perspective, tasks.py
should live in the root of generated template code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, we can drop setup.py
in both PRs (this and #6)
@@ -0,0 +1,4 @@ | |||
debug: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local invoke
configuration that. For example, setting echo: true
prints the executed command in bold, which is very convenient. Since so far it's the only setting we actually use there, we can remove the setting file.
yes
still not working on my machine
well, I don't know why but they are.
agree. |
Closing as for now we decided to stick with Makefile |
Possible alternative to #6.
In #6 (comment), @asvetlov proposed to use
pyinvoke
instead of Makefile. I've spent some time on researching this tool and here's the results:The project seems to be alive with 2.5k stars and ~60 PRs, but many of them are very old (half a year, for example).
Pros:
source <(invoke --print-completion-script=bash)
)Cons:
context
, required decorator@task
stdin
andstdout
(or redirect them to log files), but IMO we should not mute anything in order to do this tool as much transparent as possiblecontext.run()
: ResourceWarning: unclosed file pyinvoke/invoke#665)