-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add measles dataset #202
Add measles dataset #202
Conversation
Nice! Seems to be working technically, but I haven't checked science of things (I am not a scientist :)) I know nothing about measles, but if makes sense, please consider creating subdirectories, in case there will be more dataset flavors in the future. For example you could distinguish datasets by ref accession: By contrast to nextstrain.org urls, Nextclade datasets cannot be nested one inside another (in other words, only leaf directories can contain dataset files), so if we include just Additionally, it is possible to add shortcuts (aliases) (example), so you can for example alias |
Nice! As Ivan said, the would make sense to generate one additional level to the path (for example the reference, or an indication that this is just Consider using Nextclade also has no use for time information on the trees. It doesn't really hurt, but leads to unexpected behavior if users start toggling between time and divergence. So you might consider removing it for the nextclade build. |
Update dataset name and path in pathogen.json and README in anticipation of moving dataset to subdirectories.
Create a N450 subdirectory, since future measles datasets could use other parts of the genome; and also create a WHO-2012 subdirectory, since this dataset is based on genotyping guidelines provided by the WHO in 2012, and there could be future revisions to N450 genotyping.
Removes commands for adding time information to the Nextclade dataset tree, since Nextclade doesn't use this information. This change was recommended here: nextstrain/nextclade_data#202 (comment)
056f538
to
5ded9ec
Compare
5874889
to
9ded52a
Compare
Removes commands for adding time information to the Nextclade dataset tree, since Nextclade doesn't use this information. This change was recommended here: nextstrain/nextclade_data#202 (comment)
Removes temporal info from Nextclade dataset timetree, since Nextclade doesn't use this information. This change was recommended here: nextstrain/nextclade_data#202 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, Kim. This looks very good to me.
Commands for creating the tree are here: nextstrain/measles#33
3cc2476
to
1c4206c
Compare
Add a measles dataset to Nextclade.