Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairmat 2024: add attributes to NXroot #1418

Merged
merged 18 commits into from
Oct 22, 2024

Conversation

lukaspie
Copy link
Contributor

No description provided.

domna and others added 9 commits September 23, 2024 18:27
# Conflicts:
#	base_classes/NXroot.nxdl.xml
#	base_classes/NXsource.nxdl.xml
#	contributed_definitions/NXmpes.nxdl.xml
# Conflicts:
#	base_classes/NXsource.nxdl.xml
#	base_classes/nyaml/NXroot.yaml
#	base_classes/nyaml/NXsource.yaml
#	contributed_definitions/NXcalibration.nxdl.xml
#	contributed_definitions/NXenergydispersion.nxdl.xml
#	contributed_definitions/NXmpes.nxdl.xml
#	contributed_definitions/NXresolution.nxdl.xml
#	contributed_definitions/nyaml/NXcalibration.yaml
#	contributed_definitions/nyaml/NXenergydispersion.yaml
#	contributed_definitions/nyaml/NXmpes.yaml
#	contributed_definitions/nyaml/NXphotoemission.yaml
#	contributed_definitions/nyaml/NXresolution.yaml
# Conflicts:
#	base_classes/NXroot.nxdl.xml
#	base_classes/nyaml/NXroot.yaml
… removes nyaml2nxdl (#117)

* Readd collapsible features

* Restore super-concept links

* Remove nyaml2nxdl

* Use nyaml package

* Readd pyyaml
# Conflicts:
#	Makefile
#	contributed_definitions/NXcalibration.nxdl.xml
#	dev_tools/utils/nxdl_utils.py
#	requirements.txt
# Conflicts:
#	contributed_definitions/NXcg_primitive_set.nxdl.xml
#	contributed_definitions/NXcollectioncolumn.nxdl.xml
#	contributed_definitions/NXcomponent_em.nxdl.xml
#	contributed_definitions/NXcoordinate_system.nxdl.xml
#	contributed_definitions/NXcrystal_structure.nxdl.xml
#	contributed_definitions/NXcs_cpu_obj.nxdl.xml
#	contributed_definitions/NXcs_cpu_sys.nxdl.xml
#	contributed_definitions/NXcs_gpu_obj.nxdl.xml
#	contributed_definitions/NXcs_gpu_sys.nxdl.xml
#	contributed_definitions/NXcs_mm_obj.nxdl.xml
#	contributed_definitions/NXelectronanalyser.nxdl.xml
#	contributed_definitions/NXem_adf.nxdl.xml
#	contributed_definitions/NXem_base.nxdl.xml
#	contributed_definitions/NXem_conventions_ebsd.nxdl.xml
#	contributed_definitions/NXem_correlation.nxdl.xml
#	contributed_definitions/NXem_eds.nxdl.xml
#	contributed_definitions/NXem_eels.nxdl.xml
#	contributed_definitions/NXem_img.nxdl.xml
#	contributed_definitions/NXem_method.nxdl.xml
#	contributed_definitions/NXem_msr.nxdl.xml
#	contributed_definitions/NXem_sim.nxdl.xml
#	contributed_definitions/NXenergydispersion.nxdl.xml
#	contributed_definitions/NXidentifier.nxdl.xml
#	contributed_definitions/NXimage_c_set.nxdl.xml
#	contributed_definitions/NXimage_r_set.nxdl.xml
#	contributed_definitions/NXimage_r_set_diff.nxdl.xml
#	contributed_definitions/NXinteraction_vol_em.nxdl.xml
#	contributed_definitions/NXmpes.nxdl.xml
#	contributed_definitions/NXms_ipf.nxdl.xml
#	contributed_definitions/NXms_ipf_set.nxdl.xml
#	contributed_definitions/NXms_mtex_config.nxdl.xml
#	contributed_definitions/NXms_odf.nxdl.xml
#	contributed_definitions/NXms_odf_set.nxdl.xml
#	contributed_definitions/NXms_pf.nxdl.xml
#	contributed_definitions/NXms_pf_set.nxdl.xml
#	contributed_definitions/NXms_recon.nxdl.xml
#	contributed_definitions/NXroi.nxdl.xml
#	contributed_definitions/NXrotation_set.nxdl.xml
#	contributed_definitions/NXserialized.nxdl.xml
#	contributed_definitions/NXxrd.nxdl.xml
#	contributed_definitions/NXxrd_pan.nxdl.xml
# Conflicts:
#	contributed_definitions/NXcg_primitive_set.nxdl.xml
#	contributed_definitions/NXcomponent_em.nxdl.xml
#	contributed_definitions/NXcoordinate_system.nxdl.xml
#	contributed_definitions/NXcrystal_structure.nxdl.xml
#	contributed_definitions/NXcs_cpu_obj.nxdl.xml
#	contributed_definitions/NXcs_cpu_sys.nxdl.xml
#	contributed_definitions/NXcs_gpu_obj.nxdl.xml
#	contributed_definitions/NXcs_gpu_sys.nxdl.xml
#	contributed_definitions/NXcs_mm_obj.nxdl.xml
#	contributed_definitions/NXem_adf.nxdl.xml
#	contributed_definitions/NXem_base.nxdl.xml
#	contributed_definitions/NXem_conventions_ebsd.nxdl.xml
#	contributed_definitions/NXem_correlation.nxdl.xml
#	contributed_definitions/NXem_eds.nxdl.xml
#	contributed_definitions/NXem_eels.nxdl.xml
#	contributed_definitions/NXem_img.nxdl.xml
#	contributed_definitions/NXem_method.nxdl.xml
#	contributed_definitions/NXem_msr.nxdl.xml
#	contributed_definitions/NXem_sim.nxdl.xml
#	contributed_definitions/NXidentifier.nxdl.xml
#	contributed_definitions/NXimage_c_set.nxdl.xml
#	contributed_definitions/NXimage_r_set.nxdl.xml
#	contributed_definitions/NXimage_r_set_diff.nxdl.xml
#	contributed_definitions/NXinteraction_vol_em.nxdl.xml
#	contributed_definitions/NXms_ipf.nxdl.xml
#	contributed_definitions/NXms_ipf_set.nxdl.xml
#	contributed_definitions/NXms_mtex_config.nxdl.xml
#	contributed_definitions/NXms_odf.nxdl.xml
#	contributed_definitions/NXms_odf_set.nxdl.xml
#	contributed_definitions/NXms_pf.nxdl.xml
#	contributed_definitions/NXms_pf_set.nxdl.xml
#	contributed_definitions/NXms_recon.nxdl.xml
#	contributed_definitions/NXroi.nxdl.xml
#	contributed_definitions/NXrotation_set.nxdl.xml
#	contributed_definitions/NXserialized.nxdl.xml
#	contributed_definitions/NXxrd.nxdl.xml
#	contributed_definitions/NXxrd_pan.nxdl.xml
…ersion

# Conflicts:
#	applications/NXarpes.nxdl.xml
#	applications/nyaml/NXarpes.yaml
#	base_classes/NXaperture.nxdl.xml
#	base_classes/NXbeam.nxdl.xml
#	base_classes/NXdata.nxdl.xml
#	base_classes/NXdetector.nxdl.xml
#	base_classes/NXentry.nxdl.xml
#	base_classes/NXenvironment.nxdl.xml
#	base_classes/NXinstrument.nxdl.xml
#	base_classes/NXmonochromator.nxdl.xml
#	base_classes/NXsample.nxdl.xml
#	base_classes/NXsample_component.nxdl.xml
#	base_classes/NXsensor.nxdl.xml
#	base_classes/NXsource.nxdl.xml
#	base_classes/NXsubentry.nxdl.xml
#	base_classes/NXtransformations.nxdl.xml
#	base_classes/NXuser.nxdl.xml
#	base_classes/nyaml/NXaperture.yaml
#	base_classes/nyaml/NXbeam.yaml
#	base_classes/nyaml/NXdata.yaml
#	base_classes/nyaml/NXdetector.yaml
#	base_classes/nyaml/NXentry.yaml
#	base_classes/nyaml/NXenvironment.yaml
#	base_classes/nyaml/NXinstrument.yaml
#	base_classes/nyaml/NXmonochromator.yaml
#	base_classes/nyaml/NXprocess.yaml
#	base_classes/nyaml/NXroot.yaml
#	base_classes/nyaml/NXsample.yaml
#	base_classes/nyaml/NXsample_component.yaml
#	base_classes/nyaml/NXsensor.yaml
#	base_classes/nyaml/NXsource.yaml
#	base_classes/nyaml/NXsubentry.yaml
#	base_classes/nyaml/NXtransformations.yaml
#	base_classes/nyaml/NXuser.yaml
@sanbrock sanbrock mentioned this pull request Sep 29, 2024
@lukaspie lukaspie linked an issue Sep 29, 2024 that may be closed by this pull request
@phyy-nx
Copy link
Contributor

phyy-nx commented Sep 30, 2024

Proposal: accept with the noted changes.

Accepted by NIAC vote as part of NIAC2024

@lukaspie
Copy link
Contributor Author

lukaspie commented Oct 1, 2024

@sanbrock this should be more or less ready. Feel free to give a final review before other NIAC members can be tagged in.

Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaspie lukaspie merged commit 5b6daa0 into nexusformat:main Oct 22, 2024
2 checks passed
@lukaspie lukaspie deleted the fairmat-2024-nxroot branch October 22, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NXroot
5 participants