#54: remove nullable from props of ValidationPackage model

nfdi4plants · Jun 25, 2024 · 2392649 · 2392649
1 parent f88f808
commit 2392649
Show file tree

Hide file tree

Showing 4 changed files with 291 additions and 4 deletions.
diff --git a/src/PackageRegistryService/Migrations/20240625140809_NoNullableFields.Designer.cs b/src/PackageRegistryService/Migrations/20240625140809_NoNullableFields.Designer.cs
diff --git a/src/PackageRegistryService/Migrations/20240625140809_NoNullableFields.cs b/src/PackageRegistryService/Migrations/20240625140809_NoNullableFields.cs
@@ -0,0 +1,54 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace PackageRegistryService.Migrations
+{
+    /// <inheritdoc />
+    public partial class NoNullableFields : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.AlterColumn<string>(
+                name: "ReleaseNotes",
+                table: "ValidationPackages",
+                type: "text",
+                nullable: false,
+                defaultValue: "",
+                oldClrType: typeof(string),
+                oldType: "text",
+                oldNullable: true);
+
+            migrationBuilder.AlterColumn<string>(
+                name: "CQCHookEndpoint",
+                table: "ValidationPackages",
+                type: "text",
+                nullable: false,
+                defaultValue: "",
+                oldClrType: typeof(string),
+                oldType: "text",
+                oldNullable: true);
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.AlterColumn<string>(
+                name: "ReleaseNotes",
+                table: "ValidationPackages",
+                type: "text",
+                nullable: true,
+                oldClrType: typeof(string),
+                oldType: "text");
+
+            migrationBuilder.AlterColumn<string>(
+                name: "CQCHookEndpoint",
+                table: "ValidationPackages",
+                type: "text",
+                nullable: true,
+                oldClrType: typeof(string),
+                oldType: "text");
+        }
+    }
+}
diff --git a/src/PackageRegistryService/Migrations/ValidationPackageDbModelSnapshot.cs b/src/PackageRegistryService/Migrations/ValidationPackageDbModelSnapshot.cs
@@ -100,6 +100,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                         .HasColumnType("text");
 
                     b.Property<string>("CQCHookEndpoint")
+                        .IsRequired()
                         .HasColumnType("text");
 
                     b.Property<string>("Description")
@@ -114,6 +115,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                         .HasColumnType("date");
 
                     b.Property<string>("ReleaseNotes")
+                        .IsRequired()
                         .HasColumnType("text");
 
                     b.Property<string>("Summary")

diff --git a/src/PackageRegistryService/Models/ValidationPackage.cs b/src/PackageRegistryService/Models/ValidationPackage.cs
@@ -81,22 +81,22 @@ public class ValidationPackage
         /// <summary>
         /// 
         /// </summary>
-        public ICollection<AVPRIndex.Domain.OntologyAnnotation>? Tags { get; set; }
+        public ICollection<AVPRIndex.Domain.OntologyAnnotation> Tags { get; set; } = Array.Empty<AVPRIndex.Domain.OntologyAnnotation>();
 
         /// <summary>
         /// 
         /// </summary>
-        public string? ReleaseNotes { get; set; }
+        public string ReleaseNotes { get; set; } = "";
 
         /// <summary>
         /// 
         /// </summary>
-        public string? CQCHookEndpoint { get; set; }
+        public string CQCHookEndpoint { get; set; } = "";
 
         /// <summary>
         /// 
         /// </summary>
-        public ICollection<AVPRIndex.Domain.Author>? Authors { get; set; } // https://www.learnentityframeworkcore.com/relationships#navigation-properties
+        public ICollection<AVPRIndex.Domain.Author> Authors { get; set; } = Array.Empty<AVPRIndex.Domain.Author>();// https://www.learnentityframeworkcore.com/relationships#navigation-properties
 
         /// <summary>
         ///