Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use nullable fields #54

Closed
kMutagene opened this issue Jun 18, 2024 · 0 comments
Closed

Don't use nullable fields #54

kMutagene opened this issue Jun 18, 2024 · 0 comments
Assignees
@kMutagene

Comments

@kMutagene
Copy link
Member

There are some internal reasons why we use classes with default values (F# has no nullable members). So we should stop using nullable fields in the C# API models / DB fields, as this can lead to actual nulls showing up on API responses which causes problems in consuming F# applications.
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jun 18, 2024
@kMutagene kMutagene moved this to Backlog in ARCStack Jun 18, 2024
@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Jun 18, 2024
@kMutagene kMutagene self-assigned this Jun 18, 2024
@kMutagene kMutagene moved this from Backlog to Ready in ARCStack Jun 21, 2024
@kMutagene kMutagene moved this from Ready to In progress in ARCStack Jun 25, 2024
kMutagene added a commit that referenced this issue Jun 25, 2024
@kMutagene
#54: remove nullable from props of ValidationPackage model
2392649
@kMutagene kMutagene moved this from In progress to Done in ARCStack Jun 26, 2024
@kMutagene kMutagene closed this as completed by moving to Done in ARCStack Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kMutagene kMutagene

Labels
None yet
Projects
ARCStack
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kMutagene