Fuzz settings in fuzz_http3serverreq #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirlivneh
force-pushed
the
fuzz-settings
branch
2 times, most recently
from
7b32e29 to
03bc644
Compare
amirlivneh
force-pushed
the
fuzz-settings
branch
from
03bc644 to
f295808
Compare
tatsuhiro-t
reviewed
Dec 31, 2024
|
|
||
| nghttp3_settings_default(&settings); |
There was a problem hiding this comment.
This should be kept because this is how we initialize nghttp3_settings in practice.
There was a problem hiding this comment.
Makes sense. I made the change.
tatsuhiro-t
reviewed
Dec 31, 2024
fuzz/fuzz_http3serverreq.cc
Outdated
| @@ -75,4 +97,4 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | |||
| nghttp3_conn_del(conn); | |||
|
|
|||
| return 0; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Looks like the line separator is missing.
fuzz/fuzz_http3serverreq.cc
Outdated
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif // defined(__cplusplus) |
There was a problem hiding this comment.
This has been added in #293
tatsuhiro-t
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.