Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz settings in fuzz_http3serverreq #289

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Fuzz settings in fuzz_http3serverreq #289

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f295808
Fuzz settings in fuzz_http3serverreq
amirlivneh Dec 28, 2024
dbf332c
fixup! Fuzz settings in fuzz_http3serverreq
amirlivneh Dec 31, 2024
6d419e8
fixup! Fuzz settings in fuzz_http3serverreq
amirlivneh Dec 31, 2024
740b251
fixup! Fuzz settings in fuzz_http3serverreq
amirlivneh Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions fuzz/fuzz_http3serverreq.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@

#include <nghttp3/nghttp3.h>

#ifdef __cplusplus
extern "C" {
#endif // defined(__cplusplus)

#include "nghttp3_macro.h"

#ifdef __cplusplus
}
#endif // defined(__cplusplus)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been added in #293

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.


static int send_data(nghttp3_conn *conn) {
std::array<nghttp3_vec, 16> vec;
int64_t stream_id;
Expand Down Expand Up @@ -35,9 +45,21 @@ static int send_data(nghttp3_conn *conn) {
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
FuzzedDataProvider fuzzed_data_provider(data, size);
nghttp3_callbacks callbacks{};
nghttp3_settings settings;

nghttp3_settings settings;
nghttp3_settings_default(&settings);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept because this is how we initialize nghttp3_settings in practice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I made the change.

settings.max_field_section_size =
fuzzed_data_provider.ConsumeIntegralInRange<uint64_t>(0,
NGHTTP3_MAX_VARINT);
settings.qpack_max_dtable_capacity =
fuzzed_data_provider.ConsumeIntegralInRange<size_t>(0, NGHTTP3_MAX_VARINT);
settings.qpack_encoder_max_dtable_capacity =
fuzzed_data_provider.ConsumeIntegralInRange<size_t>(0, NGHTTP3_MAX_VARINT);
settings.qpack_blocked_streams =
fuzzed_data_provider.ConsumeIntegralInRange<size_t>(0, NGHTTP3_MAX_VARINT);
settings.enable_connect_protocol =
fuzzed_data_provider.ConsumeIntegral<uint8_t>();
settings.h3_datagram = fuzzed_data_provider.ConsumeIntegral<uint8_t>();

nghttp3_conn *conn;
auto rv =
Expand Down Expand Up @@ -75,4 +97,4 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
nghttp3_conn_del(conn);

return 0;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the line separator is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Loading