FIX: Ensure shape matches template during resampling #3296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jun 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3296 +/- ##
=======================================
Coverage 73.72% 73.73%
=======================================
Files 56 56
Lines 4271 4265 -6
=======================================
- Hits 3149 3145 -4
+ Misses 1122 1120 -2 ☔ View full report in Codecov by Sentry. |
The reverse of the TransformFixedParameters should match the template dimensions. This fell through the cracks because the templates tested (MNI152 variants) all have the same X and Z dimensions. Only when testing on a template with distinct values for shape did this become evident. Additionally, this removes any `FIXED_PARAMS` checks, as that is template specific and more useful for debugging the initial implementation.
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
reviewed
Jun 4, 2024
effigies
reviewed
Jun 5, 2024
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
added a commit
that referenced
this pull request
Jun 5, 2024
Alternative to (and builds on) #3296. Closes #3296. --------- Co-authored-by: mathiasg <[email protected]> Co-authored-by: Mathias Goncalves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverse of the TransformFixedParameters should match the template dimensions.
This fell through the cracks because the templates tested (MNI152 variants) all have the same X and Z dimensions. Only when testing on a template with distinct values for shape did this become evident.
Additionally, this removes any
FIXED_PARAMSchecks, as that is template specific and more useful for debugging the initial implementation.