Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Ensure shape matches template during resampling #3296

Closed
wants to merge 5 commits into from
Closed

FIX: Ensure shape matches template during resampling #3296

wants to merge 5 commits into from

Commits on Jun 4, 2024

  1. FIX: Ensure shape matches template 

    The reverse of the TransformFixedParameters should match the template dimensions.

This fell through the cracks because the templates tested (MNI152 variants) all have the same
X and Z dimensions. Only when testing on a template with distinct values for shape did this become evident.

Additionally, this removes any `FIXED_PARAMS` checks, as that is template specific and more useful for debugging the
initial implementation.
    @mgxd @effigies
    mgxd authored and effigies committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    553d7e0 View commit details
    Browse the repository at this point in the history

  2. Update fmriprep/utils/transforms.py 

    Co-authored-by: Chris Markiewicz <[email protected]>
    @mgxd @effigies
    mgxd and effigies committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    44bf370 View commit details
    Browse the repository at this point in the history

  3. STY: ruff, use trailing comma to force reshape to expand

    @effigies
    effigies committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a28212d View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. FIX: Catch cases of unexpected resampling

    @mgxd
    mgxd committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    bcc7d3e View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Chris Markiewicz <[email protected]>
    @mgxd @effigies
    mgxd and effigies authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c9619a8 View commit details
    Browse the repository at this point in the history