Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put better version attr in stable/beta derivations #118

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

cdmistman
Copy link
Contributor

for replit/nixmodules i'd like to use fenix to supply the rust toolchains. i'd like to make the name of the nixmodules something like rust-1.73:... but that's not really feasible with fenix.

this pr changes the manifest generation and derivation construction for components.

  • during manifest generation (update script), the version of the component is now included in the JSON object as a field, unedited
    • note: this has an unfortunate side-effect (see screenshot below)
  • when building the component derivation, prefers the version from the component source instead of relying solely on the date of the component or the date the component was fetched
image

@cdmistman
Copy link
Contributor Author

cdmistman commented Oct 5, 2023

fyi @figsoda CI passes when i manually run locally, the reason why it's failing in CI is because the update script needs to be run since it adds a field to the data json files

i can do this first thing in the morning to ensure reproducibility with main

@cdmistman cdmistman changed the base branch from main to staging October 29, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant