Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QoL improvement: typecheck just one test #335

Merged
merged 5 commits into from
Jul 26, 2024
Merged

QoL improvement: typecheck just one test #335

merged 5 commits into from
Jul 26, 2024

Conversation

kelloggm
Copy link
Collaborator

(on unix only, because I don't know how to write a bat script)

@kelloggm kelloggm requested a review from theron-wang July 25, 2024 21:13
theron-wang
theron-wang approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@theron-wang theron-wang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think it would be best if there was a note in DEVELOPERS.md on how to run this, though. Also, I can port everything over to batch once this is merged.

@kelloggm kelloggm enabled auto-merge (squash) July 26, 2024 12:51
@kelloggm kelloggm merged commit e7091e4 into main Jul 26, 2024
2 checks passed
@kelloggm kelloggm deleted the one-compile-check branch July 26, 2024 13:04
@theron-wang theron-wang mentioned this pull request Aug 5, 2024
Merged
kelloggm pushed a commit that referenced this pull request Aug 5, 2024
@theron-wang
Port typecheck_one_test.sh to batch and fix check_differences.bat (…
0c6ebd9 
…#349)

This ports over the changes made in #335 to Windows, and it should also
finally fix false positives regarding `check_differences.bat`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theron-wang theron-wang theron-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelloggm @theron-wang