Fixed bugs introduced while converting from Python to C++ #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing OCSort C++ code base, I noticed that few variables were not matching. On digging deeper, I found couple of bugs in the C++ code after comparing to Python code.
A comma is given instead of multiplication operator resulting in the second operand
F.transpose()
being returned instead of(F * P) * F.transpose()
:Python code:
P = (alpha * alpha) * dot(dot(F, P), F.T) + Q
Incorrect C++ code:
P = _alpha_sq * ((F * P), F.transpose()) + Q;
Correct C++ code:
P = _alpha_sq * ((F * P) * F.transpose()) + Q;
Added an inverse operation that was present in the Python code, but not in the C++ code.
Note: There is no change in line 1 and 156.