Set paths to not run on unrelated PRs #370
Conversation
marbre
changed the title
| paths: | ||
| - '.github/workflows/ci-llama.yaml' | ||
| - 'sharktank/**' | ||
| - '*requirements*.txt' | ||
| schedule: |
There was a problem hiding this comment.
I left a comment on #363 (comment). I'd rather see this run on either schedule or pull_request, push.
The workflow name also isn't consistent with others (ci-llama but Llama Benchmarking Tests name doesn't sort along with the others at https://github.com/nod-ai/SHARK-Platform/actions/workflows/ci-llama.yaml)
There was a problem hiding this comment.
Make sense. In that case, lets wait for @aviator19941 to respond to your comment and then refactor accordingly.
There was a problem hiding this comment.
Here's what I mean with sorting:
There was a problem hiding this comment.
We're going to have more models to test and benchmark, so I'd like us to get better organized about how we define workflows.
| pull_request: | ||
| paths: | ||
| - '.github/workflows/ci-llama.yaml' | ||
| - 'sharktank/**' | ||
| - '*requirements*.txt' |
There was a problem hiding this comment.
I think for the moment we should actually remove all these path filters from the workflows and start switching more checks to be required. Too many developers are ignoring CI results and relying on auto-merge, wasting multiple developer-hours a week on reverts and fix-forwards.
We could build a system like https://iree.dev/developers/general/github-actions/#opt-in-for-presubmit-jobs to get the best of both worlds (filtering and path filters), since GitHub's default implementation is completely broken :|
There was a problem hiding this comment.
I generally agree, but don't have a good feeling yet which workflows would be a good choice to be run on every PR. However, I clearly see the point. Closing this therefore.
There was a problem hiding this comment.
Every workflow that runs in less than 30 minutes.
No description provided.