Set paths to not run on unrelated PRs #370
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,10 @@ name: Llama Benchmarking Tests | |
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflows/ci-llama.yaml' | ||
| - 'sharktank/**' | ||
| - '*requirements*.txt' | ||
| schedule: | ||
|
There was a problem hiding this comment. I left a comment on #363 (comment). I'd rather see this run on either The workflow name also isn't consistent with others ( There was a problem hiding this comment. Make sense. In that case, lets wait for @aviator19941 to respond to your comment and then refactor accordingly. There was a problem hiding this comment. Here's what I mean with sorting: There was a problem hiding this comment. We're going to have more models to test and benchmark, so I'd like us to get better organized about how we define workflows. |
||
| # Weekdays at 5:00 AM UTC = 10:00 PM PST. | ||
| - cron: "0 5 * * 1-5" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the moment we should actually remove all these path filters from the workflows and start switching more checks to be required. Too many developers are ignoring CI results and relying on auto-merge, wasting multiple developer-hours a week on reverts and fix-forwards.
We could build a system like https://iree.dev/developers/general/github-actions/#opt-in-for-presubmit-jobs to get the best of both worlds (filtering and path filters), since GitHub's default implementation is completely broken :|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree, but don't have a good feeling yet which workflows would be a good choice to be run on every PR. However, I clearly see the point. Closing this therefore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every workflow that runs in less than 30 minutes.