Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor manifests to be lazier #173

Open
wants to merge 1 commit into
base: 09-30-uv_for_quadfeather
Choose a base branch
from

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Nov 11, 2024

Testing scaling to 10 billion points.


Important

Refactor tile manifest handling in Deepscatter to use a flat structure, improving scalability and performance, with updates to rendering and testing components.

  • Behavior:
    • Refactor tile manifest handling in Deeptable and Tile to use a flat manifest structure for improved scalability.
    • Update fromQuadfeather() in Deeptable.ts to load flat manifests.
    • Remove points() method from Deeptable.ts as part of refactor.
  • Rendering:
    • Adjust ReglRenderer in regl_rendering.ts to accommodate changes in tile manifest structure.
    • Update render_points() to use tile.metadata.nPoints instead of tile.manifest.nPoints.
  • Testing:
    • Add tix.spec.ts to test tile index conversion functions.
  • Misc:
    • Update package.json to include vitest for testing.
    • Remove unused imports and console logs across multiple files.

This description was created by Ellipsis for cb409c1. It will automatically update as commits are pushed.

@bmschmidt bmschmidt mentioned this pull request Nov 11, 2024
Copy link
Collaborator Author

bmschmidt commented Nov 11, 2024

@bmschmidt bmschmidt marked this pull request as ready for review November 11, 2024 17:11
@bmschmidt bmschmidt force-pushed the 11-11-refactor_manifests_to_be_lazier branch from aac2391 to 0491be5 Compare November 11, 2024 18:19
@@ -373,6 +373,7 @@ export class Scatterplot {
tileProxy,
}: DS.DataSpec): Promise<DS.Deeptable> {
if (source_url !== undefined) {
console.log('Loading from source url', source_url);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary console.log statements to avoid cluttering the console and potentially leaking sensitive information.

Suggested change
console.log('Loading from source url', source_url);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant