webGPU resources #180
webGPU resources #180
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| }) | ||
| ); | ||
|
|
||
| passEncoder.dispatchWorkgroups(size / 4 / 64); |
There was a problem hiding this comment.
The workgroup dispatch calculation size / 4 / 64 should be wrapped in Math.ceil() to prevent dropping elements when the size is not perfectly divisible by the workgroup size. Without rounding up, the last partial workgroup may be skipped, leaving some elements unprocessed.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| @compute @workgroup_size(64) | ||
| //TODOD HERE | ||
| ` }); |
There was a problem hiding this comment.
The shader module is missing its main function implementation after the @compute workgroup declaration. The code as written will fail to compile. Consider implementing the core compute shader logic here before merging.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
No description provided.