feat: Change Time from "American (AM/PM)" to "MilitaryTime/European (HH:mm)" option (#58) and DisplayAttribute for Enums in Settings (#61) #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Cool stuff ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After several days of work, I’m excited to share an update. This has been quite an interesting experience for me.
While working on #58 , I added a new feature to the SettingsManager: an Enum represented as a ComboBox. Inspired by @kawapure's suggestion, I also implemented a DisplayAttribute. This attribute allows developers to display a user-friendly string for Enum values instead of the internal variable names (e.g., "MilitaryTime" becomes "24-hour clock").
Now, when developers want to represent an Enum in the UI via a ComboBox, they can use the [Display("12-Hour Clock (AM/PM)")] attribute (or a similar custom label) above each Enum item. This enhances the UI by presenting more intuitive labels to the user.