Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: bootloader size optimizations #19178

Closed

Conversation

maciejbaczmanski
Copy link
Member

@maciejbaczmanski maciejbaczmanski commented Dec 2, 2024

Add LTO and size optimization configs for mcuboot and remove redundant configs.
Set mcuboot size to 0xD000 for nRF54Lxx.
Remove PDK overlays.

MCUboot for nRF54l15 will be built with support for ED25519
by default and application images will be signed with ED25519
signature.
The MCUboot partition size, for this configuration, is set
to 0xd000.

Signed-off-by: Dominik Ermel <[email protected]>
@maciejbaczmanski maciejbaczmanski requested a review from a team as a code owner December 2, 2024 08:22
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 2, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 2, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ❌ Toolchain
  • ❌ Build twister
  • ❌ Integration tests

Note: This message is automatically posted and updated by the CI

@maciejbaczmanski maciejbaczmanski force-pushed the matter_mcuboot_optim branch 3 times, most recently from f576d33 to b1cc3a4 Compare December 3, 2024 07:15
@maciejbaczmanski maciejbaczmanski requested a review from a team as a code owner December 3, 2024 07:34
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 3, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Copy link
Contributor

@ArekBalysNordic ArekBalysNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the internal variant. Maybe I calculated something wrong, but can see inconsistency there.

@@ -389,6 +389,8 @@ Matter samples
* Updated all Matter samples that support low-power mode to enable the :ref:`lib_ram_pwrdn` feature.
It is enabled by default for the release configuration of the :ref:`matter_lock_sample`, :ref:`matter_light_switch_sample`, :ref:`matter_smoke_co_alarm_sample`, and :ref:`matter_window_covering_sample` samples.

* Updated pm static configuration for the :ref:`zephyr:nrf54l15dk_nrf54l15` target, increasing MCUboot size to enable ED25519 signature type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ED25519 signature type enabled by default? Because I cannot find any config related to that within this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaulting is done here: #19148 , so I guess that this PR should be PR to the 19148 and they should go together.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reopened here: de-nordic#68 and applied comments resolution

Add LTO and size optimization configs for mcuboot and remove
redundant configs.
Set mcuboot size to `0xD000` for nRF54Lxx
Remove PDK overlays.

Signed-off-by: Maciej Baczmanski <[email protected]>
@maciejbaczmanski maciejbaczmanski requested a review from a team as a code owner December 3, 2024 13:35
@maciejbaczmanski
Copy link
Member Author

reopened here: de-nordic#68 and applied comments resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants