-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: wifi: radio_test: Add a single domain combo radio test #19203
base: main
Are you sure you want to change the base?
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 4a57643846aa572131a314257861bc06774469b6 more detailssdk-nrf:
Github labels
List of changed files detected by CI (40)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Need to work on the doc changes a bit and also haven't done any testing, hence leaving it in the draft state. Wanted to get an opinion on the approach before I invest any time. |
90a3f4b
to
1ba60e9
Compare
I haven't received any objections on the approach, so, opening up for review. |
1ba60e9
to
7edda92
Compare
7edda92
to
d9af837
Compare
d9af837
to
4e36351
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
4e36351
to
a3dc392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review.
Please add a Changelog entry.
samples/wifi/radio_test/single_domain/boards/nrf54l15pdk_nrf54l15_cpuapp.conf
Outdated
Show resolved
Hide resolved
a3dc392
to
0a9c81a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minor nits.
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
With the introduction of 54L15 SoC where the complete BLE stack runs on the CPUAPP itself, reorg the radio test directories based on domains. Single domain radio test is primarily for 54L15 (and other similar SoCs) which basically combines Wi-Fi and Peripheral radio test samples in to one. Signed-off-by: Chaitanya Tata <[email protected]>
Found by compliance check. Signed-off-by: Chaitanya Tata <[email protected]>
Entry for Wi-Fi radio test changed. Signed-off-by: Chaitanya Tata <[email protected]>
0a9c81a
to
4a57643
Compare
With the introduction of 54L15 SoC where the complete BLE stack runs on the CPUAPP itself, reorg the radio test directories based on domains. Single domain radio test is primarily for 54L15 (and other similar SoCs) which basically combines Wi-Fi and Peripheral radio test samples in to one.
test-sdk-wifi: sdk-nrf-pr-19203