Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: sdp: reduced IPC structures #19877

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mif1-nordic
Copy link
Contributor

@mif1-nordic mif1-nordic commented Jan 13, 2025

Depends on #19449

@mif1-nordic mif1-nordic requested review from a team as code owners January 13, 2025 13:47
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 13, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 13, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 45

Inputs:

Sources:

sdk-nrf: PR head: 64f80865d96a2b39adfc811ef717f3996925b8c3

more details

sdk-nrf:

PR head: 64f80865d96a2b39adfc811ef717f3996925b8c3
merge base: 10e197ecd2b3c9cd4c58565efa35e1b71061d0fb
target head (main): c4c374f29d6eeefb2d6c029f958323803d3f9e6c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt.c
│  │  │  │  │  ├── hrt.h
│  │  │  │  │  │ hrt.s
│  │  │  │  │ main.c
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 26
  • 🟠 Integration tests
    • 🟠 test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 3f4fe33 to 860ba08 Compare January 13, 2025 13:57
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 860ba08 to 49791bb Compare January 14, 2025 16:11
@masz-nordic masz-nordic added this to the 3.0.0 milestone Jan 14, 2025
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch 3 times, most recently from bcbe9c9 to 51738bc Compare January 15, 2025 12:51
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed manifest labels Jan 15, 2025
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch 3 times, most recently from b2f47e9 to 461afba Compare January 15, 2025 15:29
Copy link
Contributor

@magp-nordic magp-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revied only the new structures definitions.

include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 000dcf7 to 61ce62d Compare January 16, 2025 12:19
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 6f09cbe to b8f57a4 Compare January 29, 2025 14:21
@masz-nordic masz-nordic changed the title Ipc reduced structures applications: sdp: reduced IPC structures Jan 29, 2025
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch 5 times, most recently from f723bc6 to 9b273ce Compare January 30, 2025 10:49
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 9b273ce to 552cec2 Compare January 30, 2025 13:03
Copy link
Contributor

@magp-nordic magp-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little worried that you add support for more than one peripheral device along with modifying IPC structure. IIRC, previously we only stored information about more CE pins, but it was not possible to have more than one peripheral device, at least on the FLPR side. Those changes should be in a separate commit, or separate PR, if it is more convenient to you. Same goes to changing dummy cycles mechanics.

include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.h Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch 3 times, most recently from 69951ce to e859fe9 Compare February 3, 2025 11:51
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Show resolved Hide resolved
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch 2 times, most recently from c06bd4f to 2259040 Compare February 3, 2025 14:38
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 2259040 to 554eab2 Compare February 4, 2025 08:53
@mif1-nordic
Copy link
Contributor Author

I am a little worried that you add support for more than one peripheral device along with modifying IPC structure. IIRC, previously we only stored information about more CE pins, but it was not possible to have more than one peripheral device, at least on the FLPR side. Those changes should be in a separate commit, or separate PR, if it is more convenient to you. Same goes to changing dummy cycles mechanics.

@magp-nordic moved dummy cycles part to separate commit, as for multiple devices, added line do commit description

drivers/mspi/mspi_nrfe.c Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
Implemented smaller structures and reduced ammount of opcodes in IPC.
Added support for multiple target devices.

Signed-off-by: Michal Frankiewicz <[email protected]>
Implemented smaller structures and reduced ammount of opcodes in IPC.
Added support for multiple target devices.

Signed-off-by: Michal Frankiewicz <[email protected]>
Fixed dummy cycles implementation.
Changed dummy cycles limit from 32 to UINT32_MAX.

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 554eab2 to 64f8086 Compare February 4, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants