-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: sdp: reduced IPC structures #19877
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 64f80865d96a2b39adfc811ef717f3996925b8c3 more detailssdk-nrf:
Github labels
List of changed files detected by CI (6)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
3f4fe33
to
860ba08
Compare
860ba08
to
49791bb
Compare
bcbe9c9
to
51738bc
Compare
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
b2f47e9
to
461afba
Compare
461afba
to
000dcf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revied only the new structures definitions.
000dcf7
to
61ce62d
Compare
6f09cbe
to
b8f57a4
Compare
f723bc6
to
9b273ce
Compare
9b273ce
to
552cec2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little worried that you add support for more than one peripheral device along with modifying IPC structure. IIRC, previously we only stored information about more CE pins, but it was not possible to have more than one peripheral device, at least on the FLPR side. Those changes should be in a separate commit, or separate PR, if it is more convenient to you. Same goes to changing dummy cycles mechanics.
69951ce
to
e859fe9
Compare
c06bd4f
to
2259040
Compare
2259040
to
554eab2
Compare
@magp-nordic moved dummy cycles part to separate commit, as for multiple devices, added line do commit description |
Implemented smaller structures and reduced ammount of opcodes in IPC. Added support for multiple target devices. Signed-off-by: Michal Frankiewicz <[email protected]>
Implemented smaller structures and reduced ammount of opcodes in IPC. Added support for multiple target devices. Signed-off-by: Michal Frankiewicz <[email protected]>
Fixed dummy cycles implementation. Changed dummy cycles limit from 32 to UINT32_MAX. Signed-off-by: Michal Frankiewicz <[email protected]>
554eab2
to
64f8086
Compare
Depends on #19449