-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W5.10h][F11-B1]Sheikh Umar #746
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added! Close this PR after reading! :)
|
||
**MSS** | ||
1. User requests to rename person | ||
2. User enters name of person to be renamed and new name of the person to be renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use case sequence alternates between the actor and the system.
Your current case is actor -> actor -> system.
A better use case would be:
1. User requests to rename person
2. Addressbook requests for name of person.
3. User enters name of person to be renamed and new name of the person to be renamed.
...
|
||
2a. The addressbook is empty | ||
|
||
> Use case ends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the use case end in this case? Would it be good user experience to get no feedback?
|
||
2c. The name of the person that user wants to update is not in addressbook | ||
|
||
> Use case ends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the use case end in this case? Would it be good user experience to get no feedback?
I updated the Developer Guide.