Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5.10h][F11-B1]Sheikh Umar #746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions doc/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,29 @@ Use case ends.
> 3a1. AddressBook shows an error message <br>
Use case resumes at step 2

#### Use case: Rename person

**MSS**
1. User requests to rename person
2. User enters name of person to be renamed and new name of the person to be renamed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use case sequence alternates between the actor and the system.
Your current case is actor -> actor -> system.

A better use case would be:
1. User requests to rename person
2. Addressbook requests for name of person.
3. User enters name of person to be renamed and new name of the person to be renamed.
...

3. AddressBook renames the person <br>
Use case ends.

**Extensions**

2a. The addressbook is empty

> Use case ends
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the use case end in this case? Would it be good user experience to get no feedback?


2b. Name that user wants to update is the same as name of the person that user wants to rename

> 2b1. AddressBook shows an error message <br>
Use case ends

2c. The name of the person that user wants to update is not in addressbook

> Use case ends
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the use case end in this case? Would it be good user experience to get no feedback?


## Appendix C : Non Functional Requirements

1. Should work on any [mainstream OS](#mainstream-os) as long as it has Java 8 or higher installed.
Expand Down