forked from se-edu/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.5][F12-B3] Media Socializer #88
Open
shadow2496
wants to merge
416
commits into
nus-cs2103-AY1718S2:master
Choose a base branch
from
CS2103JAN2018-F12-B3:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
416 commits
Select commit
Hold shift + click to select a range
f0f4e5c
Update custom person creation parameters to hard-coded values
Nethergale caa2a73
Update xml files for XmlUtilTest
Nethergale cbeda3d
Update user guide and app title in config file
Nethergale 7906387
Re-add config.json to gitignore
Nethergale 763369d
Fix formatting in user guide
Nethergale dd9c752
Fix listing format in user guide
Nethergale 7dc07ea
Test fixing format in user guide
Nethergale b8bb6f2
Test fixing auto links in user guide
Nethergale b4a760c
Test fixing auto links in user guide
Nethergale bdaa388
Test fixing auto links in user guide
Nethergale cabaf2e
Test fixing auto links in user guide
Nethergale 070ed19
Test fixing auto links in user guide
Nethergale 6eb5c1d
Test fixing auto links in user guide
Nethergale 375646b
Test fixing auto links in user guide
Nethergale 6effc7f
Test fixing auto links in user guide
Nethergale 353a6a8
Test using table
Nethergale 6c419b5
Test formatting using table
Nethergale d719deb
Test formatting using table
Nethergale e4fafd3
Test formatting using table
Nethergale 5b5cb5c
Test putting table into note
Nethergale 21051d6
Format table in note
Nethergale ed8644b
Change formatting of table in note
Nethergale 28e856c
Change formatting of table in note
Nethergale e4d6e19
Change attributes of table
Nethergale 4d7b083
Change headers of table
Nethergale 18cd4b4
Add test cases for add platform command parser
Nethergale cf0c188
Add new line to config file
Nethergale 40a9b40
Remove config file from gitignore
Nethergale fbb3c12
Re-add config file to gitignore
Nethergale 47fb286
Untrack config file
Nethergale e0a82db
Update application version and application name
Nethergale 7c80b72
Update portfolio
Nethergale 276c280
Add login() in Account
shadow2496 5dbf120
Add authorship for collate
Nethergale 66f7a00
Merge pull request #87 from Nethergale/feature/manageSocialMediaPlatform
Nethergale cacbe23
BrowserPanel.fxml: Edit browser panel from a single Webview to 2 tabs…
KevinChuangCH f3820cf
BrowserPanel.java: Implementation of the browser in the 2nd tab. Dumm…
KevinChuangCH 3009b27
BrowserPanel.java: Change the name of the constant to improve readabi…
KevinChuangCH 0f106c5
BrowserPanelTest.java: Update the change of the constant name.
KevinChuangCH a260d38
AddressBookSystemTest.java: Update the change of the constant name.
KevinChuangCH c2091d5
BrowserPanel.java: Correct coding standard.
KevinChuangCH a47b284
BrowserPanelTest.java: Correct coding standard.
KevinChuangCH bd52c0d
AddressBookSystemTest.java: Correct coding standard.
KevinChuangCH 8f1940e
Merge pull request #90 from KevinChuangCH/UI
KevinChuangCH 1c14032
Add loginAccount() in AddressBook
shadow2496 5fa69d9
Add implementation of remove platform command
Nethergale 2682253
Fix checkstyle errors
Nethergale 4ba9a14
Update LoginCommand.execute() to generate the login dialog url
shadow2496 eabdeca
Add test case to address book parser for remove platform command
Nethergale ddf1820
Add test cases for remove platform command parser
Nethergale e703cee
SearchAllCommand.java: Create SearchAllCommand Class, no implementati…
KevinChuangCH 0601bb5
SearchAllCommand.java: Add implementation of SearchAllCommand, now th…
KevinChuangCH abf1acd
SearchAllCommandParser.java: Create new SearchAllCommandParser class,…
KevinChuangCH 4cf4c02
SearchAllCommandParser.java: Add implementation of SearchAllCommandPa…
KevinChuangCH 4d411da
AddressBookParser.java: Add the case for SearchAllCommand in the pars…
KevinChuangCH 3749fa2
Add test cases for remove platform command
Nethergale 4a107a0
Fix checkstyle errors
Nethergale e8bd5d7
Merge pull request #91 from Nethergale/feature/manageSocialMediaPlatform
Nethergale 0ab95a6
Update SampleDataUtil persons, BrowserPanel urls and BrowserPanelTest
Nethergale 4acff4b
Add collated code files
Nethergale 9b35445
SearchPersonOnAllPlatformEvent.java: Create new SearchPersonOnAllPlat…
KevinChuangCH 8a2a861
SearchAllCommand.java: Implement the actual Implementation of the Sea…
KevinChuangCH f37f698
SearchAllCommandParser.java: Implement the actual implementation of S…
KevinChuangCH 3799ed0
ParserUtil.java: Add parseSearchName method to check for the validati…
KevinChuangCH 6d13fe4
Merge pull request #96 from Nethergale/master
Nethergale 9fa268c
BrowserPanel.java: Add new handleSearchPersonOnAllPlatformEvent to ha…
KevinChuangCH 7f1b4f3
Change image of ui for readme
Nethergale 8fcafe3
Merge branch 'master' into SearchOnSocialMedia
KevinChuangCH d5326ee
Merge pull request #98 from Nethergale/master
Nethergale c4db5ac
SearchPersonOnAllPlatformEvent.java: Correct coding standard error.
KevinChuangCH 840eca0
SearchAllCommandParser.java: Correct coding standard error, remove un…
KevinChuangCH 6a2e23b
Merge branch 'SearchOnSocialMedia'
KevinChuangCH 458c794
SearchAllCommandParser.java: Correct coding standard error, remove un…
KevinChuangCH 648b60a
SearchPersonOnAllPlatformEvent.java: Correct coding standard error, a…
KevinChuangCH 5892913
Merge pull request #97 from KevinChuangCH/SearchOnSocialMedia
KevinChuangCH 5c62ae3
Merge branch 'master' of https://github.com/CS2103JAN2018-F12-B3/main
KevinChuangCH 5125eb2
Add ShowLoginDialogRequestEvent
shadow2496 97defc4
SearchFacebookCommand.javac: Create SearchFacebookCommand class, no i…
KevinChuangCH 5ee9d8d
SearchFacebookCommand.java: Add implementation of SearchFacebookComma…
KevinChuangCH c96fce0
SearchFacebookCommandParser.java: Create new SearchFacebookCommandPar…
KevinChuangCH d0b8655
SearchFacebookCommandParser.java: Add implementation of SearchFaceboo…
KevinChuangCH ae4f928
AddressBookParser.java: Add the case for SearchFacebookCommand in the…
KevinChuangCH ec7de93
SearchPersonOnAllPlatformEvent.java: Create new SearchPersonOnAllPlat…
KevinChuangCH 4ab53d8
Update user guide and collate code files of group
Nethergale accc7fd
SearchFacebookCommand.java: Implement the actual Implementation of th…
KevinChuangCH 77c5aa7
BrowserPanel.java: Add new handleSearchPersonOnFacebookEvent to handl…
KevinChuangCH 923cf91
SearchFacebookCommand.java: Correct MESSAGE_SEARCH_PERSON_SUCCESS, ad…
KevinChuangCH 2dd3141
SearchFacebookCommandParser.java: Add author.
KevinChuangCH e58eacc
SearchPersonOnFacebookEvent.java: Add author.
KevinChuangCH 9e6ce7f
SearchFacebookCommand.java: Add author.
KevinChuangCH 7fb8c37
SearchTwitterCommand.java: Create SearchTwitterCommand class, no impl…
KevinChuangCH 55e5dee
SearchTwitterCommandParser.java: Create new SearchTwitterCommandParse…
KevinChuangCH cf295bc
Add passVerificationCode() in BrowserPanel
shadow2496 b6bbb8f
SearchPersonOnTwitterEvent.java: Create new SearchPersonOnTwitterEven…
KevinChuangCH 2149402
SearchTwitterCommand.java: Implement the SearchTwitterCommand class.
KevinChuangCH 963eaf4
AddressBookParser.java: Add the case for SearchTwitterCommand in the …
KevinChuangCH 552f965
BrowserPanel.java: Add new handleSearchPersonOnTwitterEvent to handle…
KevinChuangCH d5ebac4
Merge pull request #100 from KevinChuangCH/SearchOnFacebook
KevinChuangCH 249f730
Merge branch 'master' into SearchOnTwitter
KevinChuangCH ca60390
Update AddressBookParser.java
KevinChuangCH ac97fe0
Update BrowserPanel.java
KevinChuangCH e92bd1c
Merge pull request #101 from KevinChuangCH/SearchOnTwitter
KevinChuangCH 009d090
Update Logic, Model to pass the verification code to Account
shadow2496 12ef10f
Merge pull request #99 from Nethergale/master
KevinChuangCH b75355e
Merge branch 'master' into feature/model/login_facebook
shadow2496 c71ffa5
Update the version to v1.4
shadow2496 5a2b532
Merge pull request #103 from shadow2496/setup/v1.4
shadow2496 be7db89
UserGuide.adoc: Update the User Guide to inlcude the 3 newly implemen…
KevinChuangCH 62c9752
UserGuide.adoc: Update User Guide to include information about the us…
KevinChuangCH 8cdb246
UserGuide: update the login command feature
shadow2496 37846e9
Merge pull request #104 from KevinChuangCH/UserGuideForPeerTesting
shadow2496 e2b210f
Remove MockUi.png
shadow2496 2671dd8
Merge pull request #105 from shadow2496/feature/docs/user
shadow2496 d31f075
Merge pull request #106 from shadow2496/feature/docs/readme
shadow2496 d8d8cdc
Update regex for facebook and twitter links
Nethergale 5e07fd0
Fix checkstyle errors
Nethergale 5b95a87
Merge pull request #114 from Nethergale/master
Nethergale 699c84d
Update portfolio and developer guide for changes to feature contribution
Nethergale 6962cd1
Make minor corrections to developer guide
Nethergale a0dbcd8
Make minor corrections to portfolio
Nethergale 1ba99a7
SearchPersonEvent.java: Create new SearchPersonEvent class for abstra…
KevinChuangCH caf233a
SearchCommand.java: Create new SearchCommand class to replace SearchA…
KevinChuangCH 636fe50
SearchCommandParser.java: Create new SearchCommandParser class to rep…
KevinChuangCH 445564c
SearchPersonEvent.java: Implement the SearchPersonEvent
KevinChuangCH f4edd7c
BrowserPanel.java: Create new handleSearchPersonEvent method to repla…
KevinChuangCH b3ed594
SocialMediaPlatform.java: Add MESSAGE_PLATFORM_CONSTRAINTS and isVali…
KevinChuangCH a9c5762
Facebook.java: Add PLATFORM_KEYWORD and PLATFORM_ALIAS to be use in a…
KevinChuangCH 10eb107
Twitter.java: Add PLATFORM_KEYWORD and PLATFORM_ALIAS to be use in a …
KevinChuangCH ab1d787
ParserUtil.java: Implement new parsePlatformToSearch method to check …
KevinChuangCH beb4c3e
AddressBookParser.java: Add the case for SearchCommand in the parseCo…
KevinChuangCH a607f55
SocialMediaPlatform.java: Remove extra blank line.
KevinChuangCH 83bedba
SearchCommandParser.java: Correct mistake in comment.
KevinChuangCH 9fbd088
Remove classes that are replaced by SearchCommand class, SearchComman…
KevinChuangCH 81e111f
BrowserPanel.java: Remove unused methods and imports.
KevinChuangCH 82d90c2
AddressBookParser.java: Remove cases that are replaced by SearchCommand.
KevinChuangCH 60a8b66
SearchCommand.java: Edit COMMAND_WORD to prompt the user that PLATFOR…
KevinChuangCH 48a7c2b
BrowserPanel.java: Correct coding style to follow the coding standard.
KevinChuangCH 1a7db0a
SearchCommandParser.java: Correct coding style to follow the coding s…
KevinChuangCH c12d4d7
SocialMediaPlatform.java: Correct coding style to follow the coding s…
KevinChuangCH 81a75f1
Merge pull request #117 from KevinChuangCH/AbstractSimilarCode
KevinChuangCH ad31b88
BrowserPanel.java: Abstract out common code.
KevinChuangCH c27956f
Merge pull request #123 from KevinChuangCH/AbstractSimilarCode
KevinChuangCH d7a0abb
Merge pull request #116 from Nethergale/master
Nethergale 9530e10
images: Add pictures used in Developer Guide.
KevinChuangCH 9fed818
DeveloperGuide.adoc: Minor update of Developer Guide.
KevinChuangCH a8fa0c7
chuangchengheng.adoc: Update personal portfolio.
KevinChuangCH 066ab85
SocialMediaPlatform.java: Add USERNAME_VALIDATION_REGEX and MESSAGE_U…
KevinChuangCH 2577f14
ParserUtil.java: Use USERNAME_VALIDATION_REGEX of SocialMediaPlatform…
KevinChuangCH f9f2173
SocialMediaPlatform.java: Correct coding style to follow the coding s…
KevinChuangCH 708e89b
SocialMediaPlatform.java: Correct coding style to follow the coding s…
KevinChuangCH 4b7d470
Merge pull request #124 from KevinChuangCH/CorrectUsernameCheck
KevinChuangCH 3cb6643
Update BrowserPanel to show profiles of persons
Nethergale 8ac1d3c
Change config files to correct application name
Nethergale 62fc0d6
Merge branch 'master' of https://github.com/CS2103JAN2018-F12-B3/main…
Nethergale 524e0cb
Fix checkstyle errors in browser panel
Nethergale 00019cc
Remove whitespace line
Nethergale da84dd5
Add comments to methods for browser panel
Nethergale d4f2f4a
Change method names while refactoring usages
Nethergale 73d9764
Make changes to typical persons
Nethergale 1778b40
Merge pull request #126 from Nethergale/feature/manageSocialMediaPlat…
Nethergale 7ec8a73
Make minor correction to user guide
Nethergale c926539
Add variable to browser panel
Nethergale 68c0ddc
Remove syntax error
Nethergale 2d1cbcc
Increase wait for event timeout
Nethergale 1d74395
Edit typical persons and build.gradle
Nethergale 8020989
Merge pull request #127 from Nethergale/feature/manageSocialMediaPlat…
Nethergale e457ded
Add new line
Nethergale 701161a
Rewrite some code for testing of URLs
Nethergale ecd660f
Reduce wait timeout
Nethergale 9638c59
Update travis.yml
Nethergale 34bcc34
BrowserPanel.java: Included the feature of opening and closing tab in…
KevinChuangCH a0f90af
AddressBookSystemTest.java: Replace DUMMY_PROFILE_PAGE_URL with the d…
KevinChuangCH 2160327
Merge pull request #128 from Nethergale/feature/manageSocialMediaPlat…
Nethergale 343d359
Merge branch 'master' into UpdateSearchFeature
KevinChuangCH 876d253
Update BrowserPanel.java
KevinChuangCH ee83fb0
.travis.yml: Attempt to fix Travis.
KevinChuangCH e453903
BrowserPanel.java: Fix coding style error.
KevinChuangCH 947b3de
.travis.yml: Redo previous change.
KevinChuangCH fd254dd
AddressBookSystemTest.java: Fix coding style error, remove unused imp…
KevinChuangCH a3e45d4
Attempt to fix Travis.
KevinChuangCH 990ef4b
BrowserPanel.java: Attempt to fix failing test cases on Travis.
KevinChuangCH a419da2
Attempt to fix failing test cases on Travis.
KevinChuangCH 157bfe2
images: Add images used in Developer Guide
KevinChuangCH ca4f05f
UserGuide.adoc: Update User Guide.
KevinChuangCH c8762e3
DeveloperGuide.adoc: Update Developer Guide.
KevinChuangCH 5c594d3
images: Add new images used in Developer Guide
KevinChuangCH b6f0faf
DeveloperGuide.adoc: Minor update, included screen shot of the applic…
KevinChuangCH b97f56c
images: Add images used in Developer Guide.
KevinChuangCH 4bbdfa7
DeveloperGuide.adoc: Update Developer Guide.
KevinChuangCH b1202e3
BrowserPanel.java: Replace dummy search page with actual search URL.
KevinChuangCH a6275e4
DeveloperGuide.adoc: Remove extra blank line.
KevinChuangCH a5b7525
UserGuide.adoc: Add tags to the section I have written.
KevinChuangCH c7d4278
chuangchengheng.adoc: Update the contrivbution to User Guide and Deve…
KevinChuangCH 9242677
Introduce stop-gap measure for inconsistent test case
Nethergale 1945a82
Remove unused imports
Nethergale 534d71b
Remove unused import
Nethergale 22bfca5
Merge pull request #131 from Nethergale/feature/manageSocialMediaPlat…
Nethergale 68e8334
Merge pull request #130 from KevinChuangCH/Documentation
Nethergale a432156
Merge pull request #129 from KevinChuangCH/UpdateSearchFeature
Nethergale 6e3630d
Update documentation
KevinChuangCH b52936b
DeveloperGuide.java: Correct mistake in title of the section.
KevinChuangCH 8bf0a71
Add dummy profile page url
Nethergale cf4746f
Merge pull request #134 from Nethergale/master
Nethergale 30a2f76
Add import of BrowserPanel
Nethergale 21159e5
Allow test to execute get loaded URL
Nethergale e624788
Allow test to get mappings of social media platform
Nethergale cd7d693
Remove expectedUrl assignment to actualUrl
Nethergale ea0b3ad
Replace dummy page with default page
Nethergale 9710740
Remove unused import
Nethergale e4a41a9
Remove unused variable in BrowserPanel
Nethergale b396105
Merge pull request #133 from KevinChuangCH/Documentation
KevinChuangCH 2d72638
ParserUtil.java: Add author for collate.
KevinChuangCH 4665d31
Person.java: Add author for collate.
KevinChuangCH 03b06a6
Add author for collate.
KevinChuangCH be63641
UniqueTagList.java: Add author for collate.
KevinChuangCH 3f62204
chuangchengheng.adoc: Add link to collate files.
KevinChuangCH c09db3a
Merge pull request #137 from KevinChuangCH/Documentation
KevinChuangCH e72b761
Merge pull request #138 from KevinChuangCH/Collate
KevinChuangCH 4857d84
Remove unused parameter for getExpectedUrl
Nethergale e21f764
Remove unused variable in AddressBookSystemTest
Nethergale 28ddafb
Make minor change as commit
Nethergale 0deea0f
Revert changes to parseUrl
Nethergale 4926177
Merge pull request #136 from Nethergale/test/testingCI
Nethergale 3814cd2
Add important note to add platform command of user guide
Nethergale ff81520
Add important note icon
Nethergale 54149bf
Update developer guide for add platform command
Nethergale 95168fc
Add more content to developer guide for add platform command
Nethergale 2b6aac4
Make minor corrections to developer guide and portfolio
Nethergale 3ca6e1a
Merge pull request #139 from Nethergale/feature/docs/developerGuide
Nethergale 15c0195
Add test case for search command to address book parser test
Nethergale c22549a
Add test case for add command alias
Nethergale 757e95c
Add test cases for search command parser
Nethergale b631355
Fix checkstyle errors
Nethergale 77452c8
Add various test cases for search command parser
Nethergale 31adb4c
Add one more test for search command parser
Nethergale 531f731
Merge pull request #140 from Nethergale/test/coverageImprovements
Nethergale e609005
Add collate files for group
Nethergale ba5dd06
Merge pull request #141 from Nethergale/feature/docs/collate
Nethergale 392b6bf
Change version to v1.5
Nethergale a6d5ea9
Update image file path for github io
Nethergale b09799d
Update sequence diagram image with less spacing
Nethergale 2484b93
Add paragraph on data encryption
Nethergale 83a3123
Fix merge conflicts
shadow2496 cefd37f
Merge branch 'master' into feature/model/login_facebook
shadow2496 1992fb1
Merge pull request #102 from shadow2496/feature/model/login_facebook
shadow2496 e1b14c9
Add annotations for collate
shadow2496 104ac91
Add collated files
shadow2496 e71c3f7
Merge pull request #143 from shadow2496/collate/shadow2496
shadow2496 d483bbb
Merge branch 'master' of https://github.com/CS2103JAN2018-F12-B3/main…
Nethergale b026f7b
Merge pull request #142 from Nethergale/feature/releasePreparation
Nethergale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.