[Silas Yeo] iP #485

comicalromance · 2022-08-27T08:57:24Z

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 🐱

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Duke {
    public static void main(String[] args) {
        new Duke(FILE_LOCATION, FOLDER_LOCATION).run();
    }
}

Also reimplemented bye

did the OOP

This reverts commit ba7ef1a.

This reverts commit b7dff63.

Update to use getter for retrieving TaskList

tingkai-mai

LGTM! I think I would suggest renaming some of the enum values to make it clearer, and perhaps throw/catch exceptions using DukeException rather than Exception.

src/main/java/duke/command/Command.java

src/main/java/duke/command/DeleteCommand.java

src/main/java/duke/task/Task.java

src/main/java/duke/Parser.java

src/main/java/duke/Storage.java

Made modifications to several access modifiers, method names, enum values and exceptions returned.

rexong

Your code looks good. Most of it is following the coding standard! Just some of the minor suggestions regarding your method and attributes naming.

rexong · 2022-09-01T03:52:09Z

src/main/java/duke/DialogBox.java

+    @FXML
+    private Label dialog;
+    @FXML
+    private ImageView displayPicture;


Perhap it is better to name is as a noun? example pictureDiplayer.

rexong · 2022-09-01T03:55:08Z

src/main/java/duke/Duke.java

+        this(FILE_LOCATION, FOLDER_LOCATION);
+    }
+
+    public boolean getLoaded() {


Maybe the method name can be changed to isLoaded instead?

rexong · 2022-09-01T04:00:12Z

src/test/java/duke/ParserTest.java

+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+
+import org.junit.jupiter.api.Test;
+
+import duke.command.EventCommand;
+import duke.command.ExitCommand;
+import duke.command.MarkCommand;
+import duke.command.UnmarkCommand;


I like how your import statements are in order. 👍

tanhl2000

Overall great job with the code! Coding standards mostly followed as well.

tanhl2000 · 2022-09-04T09:27:31Z

src/main/java/duke/Ui.java

+            if (duke.getLoaded()) {
+                print("File successfully loaded!");
+            } else {
+                print("Error parsing load file");


This can be put under Exception handling instead as it is an error message that should show with an exception. DukeException could also be expanded upon to have multiple more specific exceptions.

mainClassName in the Gradle config is set to duke.Duke. The current main class should be duke.Launcher instead. The variable has thus been changed to duke.Launcher.

Some methods were missing assertions that could be useful for developers. Assertions could be used to make sure unexpected behaviour does not occur during runtime. Let's add assert statements to two segments of code: * In Parser, an assert in getTaskName was added to ensure the input array has more than one element, indicating a name is present * In TaskList, an assert in the constructor was added to ensure that if the task parsed is a ToDo (msg.length == 1), that no date has been parsed as expected.

Parser method is extensive with numerous duplicate code fragments. Excessively long code is difficult to both read and debug. Let's refactor code by extracting two methods: * create parseDateTime to convert string into LocalDateTime * create tokenizeInput to convert string into tokens with error handling

Add assertions to important methods

Refactor parse method in Parser

There is no simple way to organize tasks in the task list. Users who want to sort their tasks by upcoming deadline or alphabetical order could not do so easily. Let's add a sort command that allows users to sort the list either alphabetically or chronologically, and in ascending or descending order. Let's also refactor the Task class to include time as well.

Let's add more JavaDoc comments to previously undocumented code.

Sort command only parses user input if it strictly matches the listed parameters. Users need to type entire parameter, which is long and not user-friendly. Let's check if user input matches the starting characters of the parameter instead of the whole string.

Error messages are undifferentiated from normal Duke messages. Users may be unsure when they are getting error messages. Let's add an error message dialog to better distinguish the two.

Let's update the user guide for a more user-friendly experience.

Remove duplicate entry for list in user guide.

damithc and others added 28 commits July 31, 2022 17:20

Add Gradle support

556af3f

Level-1

03a75f2

Level-2

7d081d8

Level-3

7b5719d

Level-4

01f0835

A-TextUiTesting

b2b5830

Level-5

c855b81

Level-6

8282e53

A-Enums

ce7b522

Add save and load functionality (not complete)

c119ff9

Finish Adding save and load functionality

51af9f1

Change save file location

ad76935

Add date time functionality

0547b4d

Merge branch 'branch-Level-8'

06322ce

Fix load function with date format

c07683e

Also reimplemented bye

Add OOP

34e73e4

did the OOP

Add packaging

e38995c

Merge branch 'add-gradle-support'

ac99107

Add JUnit tests

4e110fc

Modify location and gradle class

48a1449

Add JavaDoc for main classes

ba7ef1a

Revert "Add JavaDoc for main classes"

b7dff63

This reverts commit ba7ef1a.

Modify code to adhere to standards

e0710d7

Add Find command

0de32ff

Revert "Revert "Add JavaDoc for main classes""

f1b85d4

This reverts commit b7dff63.

Merge branch 'branch-Level-9'

d42a42c

Merge branch 'branch-A-CodingStandard'

43db764

Update FindCommand

636c7fd

Update to use getter for retrieving TaskList

tingkai-mai reviewed Aug 30, 2022

View reviewed changes

Revise code under review

c52e06b

Made modifications to several access modifiers, method names, enum values and exceptions returned.

comicalromance added 2 commits August 30, 2022 22:47

Add CheckStyle and Modify code accordingly

10722be

Add GUI

028673d

rexong reviewed Sep 1, 2022

View reviewed changes

tanhl2000 reviewed Sep 4, 2022

View reviewed changes

comicalromance added 12 commits September 7, 2022 04:27

Update Main class for Gradle

1cc8b00

mainClassName in the Gradle config is set to duke.Duke. The current main class should be duke.Launcher instead. The variable has thus been changed to duke.Launcher.

Merge pull request #1 from comicalromance/branch-A-Assertions

0022f5d

Add assertions to important methods

Merge branch 'master' into branch-A-CodeQuality

8bc5374

Merge pull request #2 from comicalromance/branch-A-CodeQuality

6c36867

Refactor parse method in Parser

Added JavaDoc comments

b75d741

Let's add more JavaDoc comments to previously undocumented code.

Update sort command

596e71e

Sort command only parses user input if it strictly matches the listed parameters. Users need to type entire parameter, which is long and not user-friendly. Let's check if user input matches the starting characters of the parameter instead of the whole string.

Update UI

43e3903

Error messages are undifferentiated from normal Duke messages. Users may be unsure when they are getting error messages. Let's add an error message dialog to better distinguish the two.

Update User Guide

0d610a4

Let's update the user guide for a more user-friendly experience.

Remove Duplicate in UG

4e0928b

Remove duplicate entry for list in user guide.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Silas Yeo] iP #485

[Silas Yeo] iP #485

comicalromance commented Aug 27, 2022 •

edited

Loading

tingkai-mai left a comment

rexong left a comment

rexong Sep 1, 2022

rexong Sep 1, 2022

rexong Sep 1, 2022

tanhl2000 left a comment

tanhl2000 Sep 4, 2022

[Silas Yeo] iP #485

Are you sure you want to change the base?

[Silas Yeo] iP #485

Conversation

comicalromance commented Aug 27, 2022 • edited Loading

DukePro

Features:

tingkai-mai left a comment

Choose a reason for hiding this comment

rexong left a comment

Choose a reason for hiding this comment

rexong Sep 1, 2022

Choose a reason for hiding this comment

rexong Sep 1, 2022

Choose a reason for hiding this comment

rexong Sep 1, 2022

Choose a reason for hiding this comment

tanhl2000 left a comment

Choose a reason for hiding this comment

tanhl2000 Sep 4, 2022

Choose a reason for hiding this comment

comicalromance commented Aug 27, 2022 •

edited

Loading