-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silas Yeo] iP #485
base: master
Are you sure you want to change the base?
[Silas Yeo] iP #485
Commits on Jul 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 556af3f - Browse repository at this point
Copy the full SHA 556af3fView commit details
Commits on Aug 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 03a75f2 - Browse repository at this point
Copy the full SHA 03a75f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d081d8 - Browse repository at this point
Copy the full SHA 7d081d8View commit details
Commits on Aug 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7b5719d - Browse repository at this point
Copy the full SHA 7b5719dView commit details
Commits on Aug 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 01f0835 - Browse repository at this point
Copy the full SHA 01f0835View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2b5830 - Browse repository at this point
Copy the full SHA b2b5830View commit details -
Configuration menu - View commit details
-
Copy full SHA for c855b81 - Browse repository at this point
Copy the full SHA c855b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8282e53 - Browse repository at this point
Copy the full SHA 8282e53View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce7b522 - Browse repository at this point
Copy the full SHA ce7b522View commit details
Commits on Aug 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c119ff9 - Browse repository at this point
Copy the full SHA c119ff9View commit details
Commits on Aug 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 51af9f1 - Browse repository at this point
Copy the full SHA 51af9f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad76935 - Browse repository at this point
Copy the full SHA ad76935View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0547b4d - Browse repository at this point
Copy the full SHA 0547b4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06322ce - Browse repository at this point
Copy the full SHA 06322ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c07683e - Browse repository at this point
Copy the full SHA c07683eView commit details
Commits on Aug 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 34e73e4 - Browse repository at this point
Copy the full SHA 34e73e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e38995c - Browse repository at this point
Copy the full SHA e38995cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac99107 - Browse repository at this point
Copy the full SHA ac99107View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e110fc - Browse repository at this point
Copy the full SHA 4e110fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48a1449 - Browse repository at this point
Copy the full SHA 48a1449View commit details
Commits on Aug 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ba7ef1a - Browse repository at this point
Copy the full SHA ba7ef1aView commit details -
Revert "Add JavaDoc for main classes"
This reverts commit ba7ef1a.
Configuration menu - View commit details
-
Copy full SHA for b7dff63 - Browse repository at this point
Copy the full SHA b7dff63View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0710d7 - Browse repository at this point
Copy the full SHA e0710d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0de32ff - Browse repository at this point
Copy the full SHA 0de32ffView commit details -
Revert "Revert "Add JavaDoc for main classes""
This reverts commit b7dff63.
Configuration menu - View commit details
-
Copy full SHA for f1b85d4 - Browse repository at this point
Copy the full SHA f1b85d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d42a42c - Browse repository at this point
Copy the full SHA d42a42cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43db764 - Browse repository at this point
Copy the full SHA 43db764View commit details -
Update to use getter for retrieving TaskList
Configuration menu - View commit details
-
Copy full SHA for 636c7fd - Browse repository at this point
Copy the full SHA 636c7fdView commit details
Commits on Aug 30, 2022
-
Made modifications to several access modifiers, method names, enum values and exceptions returned.
Configuration menu - View commit details
-
Copy full SHA for c52e06b - Browse repository at this point
Copy the full SHA c52e06bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10722be - Browse repository at this point
Copy the full SHA 10722beView commit details
Commits on Aug 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 028673d - Browse repository at this point
Copy the full SHA 028673dView commit details
Commits on Sep 6, 2022
-
mainClassName in the Gradle config is set to duke.Duke. The current main class should be duke.Launcher instead. The variable has thus been changed to duke.Launcher.
Configuration menu - View commit details
-
Copy full SHA for 1cc8b00 - Browse repository at this point
Copy the full SHA 1cc8b00View commit details -
Add assertions to important methods
Some methods were missing assertions that could be useful for developers. Assertions could be used to make sure unexpected behaviour does not occur during runtime. Let's add assert statements to two segments of code: * In Parser, an assert in getTaskName was added to ensure the input array has more than one element, indicating a name is present * In TaskList, an assert in the constructor was added to ensure that if the task parsed is a ToDo (msg.length == 1), that no date has been parsed as expected.
Configuration menu - View commit details
-
Copy full SHA for 89bbc71 - Browse repository at this point
Copy the full SHA 89bbc71View commit details
Commits on Sep 7, 2022
-
Refactor parse method in Parser
Parser method is extensive with numerous duplicate code fragments. Excessively long code is difficult to both read and debug. Let's refactor code by extracting two methods: * create parseDateTime to convert string into LocalDateTime * create tokenizeInput to convert string into tokens with error handling
Configuration menu - View commit details
-
Copy full SHA for 8194369 - Browse repository at this point
Copy the full SHA 8194369View commit details -
Merge pull request #1 from comicalromance/branch-A-Assertions
Add assertions to important methods
Configuration menu - View commit details
-
Copy full SHA for 0022f5d - Browse repository at this point
Copy the full SHA 0022f5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bc5374 - Browse repository at this point
Copy the full SHA 8bc5374View commit details -
Merge pull request #2 from comicalromance/branch-A-CodeQuality
Refactor parse method in Parser
Configuration menu - View commit details
-
Copy full SHA for 6c36867 - Browse repository at this point
Copy the full SHA 6c36867View commit details -
There is no simple way to organize tasks in the task list. Users who want to sort their tasks by upcoming deadline or alphabetical order could not do so easily. Let's add a sort command that allows users to sort the list either alphabetically or chronologically, and in ascending or descending order. Let's also refactor the Task class to include time as well.
Configuration menu - View commit details
-
Copy full SHA for 4aff51e - Browse repository at this point
Copy the full SHA 4aff51eView commit details
Commits on Sep 19, 2022
-
Let's add more JavaDoc comments to previously undocumented code.
Configuration menu - View commit details
-
Copy full SHA for b75d741 - Browse repository at this point
Copy the full SHA b75d741View commit details -
Sort command only parses user input if it strictly matches the listed parameters. Users need to type entire parameter, which is long and not user-friendly. Let's check if user input matches the starting characters of the parameter instead of the whole string.
Configuration menu - View commit details
-
Copy full SHA for 596e71e - Browse repository at this point
Copy the full SHA 596e71eView commit details -
Error messages are undifferentiated from normal Duke messages. Users may be unsure when they are getting error messages. Let's add an error message dialog to better distinguish the two.
Configuration menu - View commit details
-
Copy full SHA for 43e3903 - Browse repository at this point
Copy the full SHA 43e3903View commit details -
Let's update the user guide for a more user-friendly experience.
Configuration menu - View commit details
-
Copy full SHA for 0d610a4 - Browse repository at this point
Copy the full SHA 0d610a4View commit details -
Remove duplicate entry for list in user guide.
Configuration menu - View commit details
-
Copy full SHA for 4e0928b - Browse repository at this point
Copy the full SHA 4e0928bView commit details