Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silas Yeo] iP #485

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Commits on Jul 31, 2022

  1. Add Gradle support

    damithc authored and damithc committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    556af3f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Level-1

    comicalromance committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    03a75f2 View commit details
    Browse the repository at this point in the history
  2. Level-2

    comicalromance committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    7d081d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Level-3

    comicalromance committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    7b5719d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Level-4

    comicalromance committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    01f0835 View commit details
    Browse the repository at this point in the history
  2. A-TextUiTesting

    comicalromance committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    b2b5830 View commit details
    Browse the repository at this point in the history
  3. Level-5

    comicalromance committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    c855b81 View commit details
    Browse the repository at this point in the history
  4. Level-6

    comicalromance committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    8282e53 View commit details
    Browse the repository at this point in the history
  5. A-Enums

    comicalromance committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    ce7b522 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Configuration menu
    Copy the full SHA
    c119ff9 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2022

  1. Configuration menu
    Copy the full SHA
    51af9f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad76935 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0547b4d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    06322ce View commit details
    Browse the repository at this point in the history
  5. Fix load function with date format

    Also reimplemented bye
    aroldoraegan committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    c07683e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2022

  1. Add OOP

    did the OOP
    comicalromance committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    34e73e4 View commit details
    Browse the repository at this point in the history
  2. Add packaging

    comicalromance committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    e38995c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac99107 View commit details
    Browse the repository at this point in the history
  4. Add JUnit tests

    comicalromance committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    4e110fc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    48a1449 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Configuration menu
    Copy the full SHA
    ba7ef1a View commit details
    Browse the repository at this point in the history
  2. Revert "Add JavaDoc for main classes"

    This reverts commit ba7ef1a.
    comicalromance committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b7dff63 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e0710d7 View commit details
    Browse the repository at this point in the history
  4. Add Find command

    comicalromance committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    0de32ff View commit details
    Browse the repository at this point in the history
  5. Revert "Revert "Add JavaDoc for main classes""

    This reverts commit b7dff63.
    comicalromance committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    f1b85d4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d42a42c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    43db764 View commit details
    Browse the repository at this point in the history
  8. Update FindCommand

    Update to use getter for retrieving TaskList
    comicalromance committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    636c7fd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Revise code under review

    Made modifications to several access modifiers, method names, enum values and exceptions returned.
    comicalromance committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    c52e06b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10722be View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Add GUI

    comicalromance committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    028673d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Update Main class for Gradle

    mainClassName in the Gradle config is set to duke.Duke.
    
    The current main class should be duke.Launcher instead.
    
    The variable has thus been changed to duke.Launcher.
    comicalromance committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    1cc8b00 View commit details
    Browse the repository at this point in the history
  2. Add assertions to important methods

    Some methods were missing assertions that could be useful for
    developers.
    
    Assertions could be used to make sure unexpected behaviour does not
    occur during runtime.
    
    Let's add assert statements to two segments of code:
    * In Parser, an assert in getTaskName was added to ensure the input
    array has more than one element, indicating a name is present
    * In  TaskList, an assert in the constructor was added to ensure that
    if the task parsed is a ToDo (msg.length == 1), that no date has been
    parsed as expected.
    comicalromance committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    89bbc71 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Refactor parse method in Parser

    Parser method is extensive with numerous duplicate code fragments.
    
    Excessively long code is difficult to both read and debug.
    
    Let's refactor code by extracting two methods:
    * create parseDateTime to convert string into LocalDateTime
    * create tokenizeInput to convert string into tokens with error
    handling
    comicalromance committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8194369 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from comicalromance/branch-A-Assertions

    Add assertions to important methods
    comicalromance authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0022f5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8bc5374 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2 from comicalromance/branch-A-CodeQuality

    Refactor parse method in Parser
    comicalromance authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6c36867 View commit details
    Browse the repository at this point in the history
  5. Add sort functionality

    There is no simple way to organize tasks in the task list.
    
    Users who want to sort their tasks by upcoming deadline or alphabetical
    order could not do so easily.
    
    Let's add a sort command that allows users to sort the list either
    alphabetically or chronologically, and in ascending or descending
    order.
    
    Let's also refactor the Task class to include time as well.
    comicalromance committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4aff51e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Added JavaDoc comments

    Let's add more JavaDoc comments to previously undocumented code.
    comicalromance committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    b75d741 View commit details
    Browse the repository at this point in the history
  2. Update sort command

    Sort command only parses user input if it strictly matches the listed parameters.
    Users need to type entire parameter, which is long and not user-friendly.
    
    Let's check if user input matches the starting characters of the parameter instead of the whole string.
    comicalromance committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    596e71e View commit details
    Browse the repository at this point in the history
  3. Update UI

    Error messages are undifferentiated from normal Duke messages.
    Users may be unsure when they are getting error messages.
    
    Let's add an error message dialog to better distinguish the two.
    comicalromance committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    43e3903 View commit details
    Browse the repository at this point in the history
  4. Update User Guide

    Let's update the user guide for a more user-friendly experience.
    comicalromance committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    0d610a4 View commit details
    Browse the repository at this point in the history
  5. Remove Duplicate in UG

    Remove duplicate entry for list in user guide.
    comicalromance committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    4e0928b View commit details
    Browse the repository at this point in the history