Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #699 NTR for blood vessels that drain and/or supply #782

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Fixes #699 NTR for blood vessels that drain and/or supply #782

merged 8 commits into from
Feb 6, 2024

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #699 NTR for blood vessels that drain and/or supply.
Also fixes obophenotype/uberon#2831.
Labels have been discussed internally in EBI but suggestions to improve/shorten them are welcome.

matentzn
matentzn reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this, but would prefer a @cmungall or @balhoff because I am not great at RO modelling. Maybe share with them on slack with not that its urgent.

src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
src/ontology/ro-edit.owl Show resolved Hide resolved
@aleixpuigb
Copy link
Collaborator Author

I approve this, but would prefer a @cmungall or @balhoff because I am not great at RO modelling. Maybe share with them on slack with not that its urgent.

Thank you for looking into it, @matentzn. I will!

anitacaron
anitacaron requested changes Feb 1, 2024
View reviewed changes
src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
@anitacaron anitacaron requested a review from balhoff February 1, 2024 13:55
@anitacaron anitacaron self-requested a review February 1, 2024 14:03
anitacaron
anitacaron previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, I approve. But it still needs the ontology review.

@aleixpuigb
Update directly_supplies_drains
64cd28c 
Updates label to 'directly supplies and drains', the domain is capillary (imported) and is a subproperty of 'supplies' and 'drains'
@anitacaron anitacaron merged commit 6801458 into oborel:master Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balhoff balhoff balhoff approved these changes

@anitacaron anitacaron anitacaron approved these changes

@matentzn matentzn Awaiting requested review from matentzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NTR: supplies blood to; drains blood from Add directly_supplies_drains
4 participants
@aleixpuigb @balhoff @anitacaron @matentzn