Fix registration URL #275
Merged
Fix registration URL #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urllib chokes on this, and does not include the prefix needed. see redmine https://lcoglobal.redmineup.com/issues/1934
…he url This checks that /accounts/register exists within the email text.
jnation3406
approved these changes
Nov 8, 2023
It seems we need this when running a matrix of different python versions, as coveralls errors out when we send multiple reports for the same job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really don't understand this one, but apparently urllb stopped playing nicely with us when we had double-slashes. Perhaps this never worked?
Users were getting URLs of the form https://observe.lco.global/[email protected] instead of https://observe.lco.global/accounts/register/[email protected]
In any case, I've updated a test too. I'm a little busy today but can we coordinate a deploy sometime?