Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registration URL #275

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Fix registration URL #275

merged 6 commits into from
Nov 9, 2023

Commits on Nov 8, 2023

  1. Remove leading / on url param 

    urllib chokes on this, and does not include the prefix needed. see redmine https://lcoglobal.redmineup.com/issues/1934
    @mgdaily
    mgdaily committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f77af2b View commit details
    Browse the repository at this point in the history

  2. Add test to ensure urllib doesn't strip out the registration bit of t… 

    …he url

This checks that /accounts/register exists within the email text.
    @mgdaily
    mgdaily committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9e58703 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Try using coveralls github action in place of python coveralls

    @mgdaily
    mgdaily committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    53518f0 View commit details
    Browse the repository at this point in the history

  2. Add parallel build to coveralls 

    It seems we need this when running a matrix of different python versions, as coveralls errors out when we send multiple reports for the same job.
    @mgdaily
    mgdaily committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8bb10f8 View commit details
    Browse the repository at this point in the history

  3. Move finish block under jobs, after run_tests

    @mgdaily
    mgdaily committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    672138f View commit details
    Browse the repository at this point in the history

  4. Update pyproject and changelog

    @mgdaily
    mgdaily committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d0adaa9 View commit details
    Browse the repository at this point in the history