test(pkg): Check from which directory a ./cmd is picked
#11551
Conversation
|
Such tests are merged when the corresponding issues are fixed, aren’t they? |
No, usually we commit the current error message (with a bit of text explaining what is going wrong, so if someone fixes the issue the test changes and it is clear that this is in fact, expected) and the change in the test shows that the issue was fixed. |
Great! I’ve updated the test to suppress the output to make it portable. (My assumption that failing tests were not merged was based on this comment) |
Oh, I think this refers to a existing, flaky test that has been flaky for a very long time and I think has actually been fixed since. |
| > (write-file configure "#!/bin/sh\necho Package configured\n") | ||
| > (run chmod +x configure) | ||
| > (run sh configure) | ||
| > (run ./configure))) |
There was a problem hiding this comment.
Why is it running configure twice here? Is one failing or are both failing?
There was a problem hiding this comment.
It was my work around. You’re right: that was cryptic. I made all that explicit.
There was a problem hiding this comment.
Ah, this makes a lot more sense and is well understandable now. Thanks!
Test from which directory local commands, such as `./configure`, are called The version from the sandbox should be picked, as they could have been created or modified by previous build commands (such as `patch`) This is a simplified reproducer for ocaml#11514 Signed-off-by: Samuel Hym <[email protected]>
| > (write-file configure "#!/bin/sh\necho Package configured\n") | ||
| > (run chmod +x configure) | ||
| > (run sh configure) | ||
| > (run ./configure))) |
There was a problem hiding this comment.
Ah, this makes a lot more sense and is well understandable now. Thanks!
Test from which directory local commands, such as
./configure, are called.The version from the sandbox should be picked, as they could have been created or modified by previous build commands (such as
patch).This is a simplified reproducer for #11514.