Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pkg): Check from which directory a ./cmd is picked #11551

Merged
merged 1 commit into from
Mar 24, 2025
Merged

test(pkg): Check from which directory a ./cmd is picked #11551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions test/blackbox-tests/test-cases/pkg/run-local.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
Test that local commands, such as `./configure`, are called from the sandbox, as
they could have been created or modified by previous build commands (such as
`patch`)

$ . ./helpers.sh

$ make_lockdir
$ cat >dune.lock/test.pkg <<EOF
> (version 0.0.1)
> (build
> (progn
> (write-file configure "#!/bin/sh\necho Package configured\n")
> (run chmod +x configure)
> (run ./configure)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it running configure twice here? Is one failing or are both failing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my work around. You’re right: that was cryptic. I made all that explicit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this makes a lot more sense and is well understandable now. Thanks!

> EOF

Now build the package per se. The output is suppressed for now as `./configure`
fails with an OS-dependent error (when it cannot find the script in the sources)
so we can only observe the failure until this is fixed.

$ build_pkg test 2> /dev/null
[1]

Note that this can be worked around for now calling explicitly `sh` instead:

$ cat >dune.lock/test.pkg <<EOF
> (version 0.0.1)
> (build
> (progn
> (write-file configure "#!/bin/sh\necho Package configured\n")
> (run chmod +x configure)
> (run sh configure)))
> EOF
$ build_pkg test
Package configured
Loading