Adjust common flags passed to Cygwin setup #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2024
dra27
force-pushed
the
fix-setup-hang
branch
2 times, most recently
from
a67acf2
to
c9e71db
Compare
|
It turns out that this can be solved in setup-ocaml by ensuring that Cygwin's setup registry key is restored as part of the action. I'm therefore not certain that we have to do this for 2.2.0 |
Always pass --no-version-check and --no-write-registry: - Setup should have been updated, so the version check is an interactive risk - Running setup on a root shouldn't interfere with the user's most recent settings (although for most users this should make no difference)
dra27
changed the title
--site to Cygwin setup when --confirm-level is unsafe-yes
dra27
changed the title
|
This is no longer required for 2.2.0 - the adjustments in it are probably worth including in 2.2.1, however. |
Given that the user may be prompted, ensure that the dialogs can be used!
|
Oh dear, I appear to need to U-turn! There is an issue with this which probably is worth addressing for 2.2.0 - if the user happens to end up even interactively with an external Cygwin which needs input, then we've turned the dialogues off, which is bad. I've added a commit to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6041 - an additional option might be to explicitly abort when run non-interactively as well, but it's getting a bit niche because if you're non-interactive and expecting depext to work with an external Cygwin then clearly you must have specified
--confirm-level unsafe-yes.Backport into 2.2 in #6057