Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 애니 목록 페이지에서 카드 컴포넌트 변경 #305 #307

Merged
merged 13 commits into from
Nov 22, 2023

Conversation

chanwukim
Copy link
Contributor

📝 개요

스크린샷 2023-11-20 오전 8 25 49

🚀 변경사항

이제 width 100%로 애니 포스터가 짤리는 일이 없어졌어요

🔗 관련 이슈

#305

➕ 기타

@chanwukim chanwukim added the refactor 리팩토링 label Nov 19, 2023
@chanwukim chanwukim self-assigned this Nov 19, 2023
@presentKey
Copy link
Collaborator

presentKey commented Nov 20, 2023

오른쪽 여백이 살짝 더 넓은거같은데, 화면에 딱 맞는게 더 괜찮아보여요!

@chanwukim
Copy link
Contributor Author

오른쪽 여백이 살짝 더 넓은거같은데, 화면에 딱 맞는게 더 괜찮아보여요!

width가 고정이라 그런것같은데, 미디어 쿼리를 state로 관리해서 100%로 바뀌게 할까요??

@presentKey
Copy link
Collaborator

width가 고정이라 그런것같은데, 미디어 쿼리를 state로 관리해서 100%로 바뀌게 할까요??

디코에 올린 영상 확인부탁드립니다~

@presentKey presentKey self-assigned this Nov 21, 2023
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5fba900
Status: ✅  Deploy successful!
Preview URL: https://8148d4f6.oduck-client.pages.dev
Branch Preview URL: https://refactor-305.oduck-client.pages.dev

View logs

Copy link
Collaborator

@presentKey presentKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

애니 페이지, 검색 페이지 적용됐습니다!

_.-.Chrome.2023-11-22.01-38-25.mp4

@chanwukim
Copy link
Contributor Author

애니 페이지, 검색 페이지 적용됐습니다!

깔끔하고 좋습니다!

Copy link
Contributor

@imdaxsz imdaxsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@presentKey presentKey merged commit 1ea4d36 into develop Nov 22, 2023
2 checks passed
@presentKey presentKey deleted the refactor/305 branch November 22, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants