Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 애니 목록 페이지에서 카드 컴포넌트 변경 #305 #307

Merged
merged 13 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/features/animes/components/AnimeCard/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Star } from "@phosphor-icons/react";
import { Link } from "react-router-dom";

import { calcStarRatingAvg } from "@/utils/common";

Expand All @@ -26,6 +25,9 @@ export interface AnimeCardProps {

/** 페이지 이동 */
onClick: (animeId: number, e: React.MouseEvent) => void;

/** style: 사용되는 곳에 따라 width를 다르게 설정 */
display?: "default" | "carousel";
}

export default function AnimeCard({
Expand All @@ -34,10 +36,16 @@ export default function AnimeCard({
title,
starScoreAvg,
onClick,
display = "default",
}: AnimeCardProps) {
return (
<AnimeCardContainer onClick={(e: React.MouseEvent) => onClick(id, e)}>
<Image image={thumbnail} />
<AnimeCardContainer
onClick={(e: React.MouseEvent) => onClick(id, e)}
display={display}
>
<div className="image-container">
<Image className="image" image={thumbnail} />
</div>
<InfoContainer>
<Title>{title}</Title>
<Rating>
Expand Down
45 changes: 42 additions & 3 deletions src/features/animes/components/AnimeCard/style.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,54 @@
import { css } from "@emotion/react";
import styled from "@emotion/styled";

import { AnimeCardProps } from ".";

interface ImageProps {
image: string;
}

export const AnimeCardContainer = styled.div`
width: 100%;
export const AnimeCardContainer = styled.div<Pick<AnimeCardProps, "display">>`
width: 100%; // display === 'carousel';
cursor: pointer;

${({ theme, display }) =>
display === "default" &&
css`
width: calc(50% - 4px);
&:nth-of-type(odd) {
margin-right: 8px;
}
${theme.mq("sm")} {
width: calc(33% - 4px);
&:nth-of-type(odd) {
margin-right: 0;
}
&:not(:nth-of-type(3n)) {
margin-right: 8px;
}
}

& .image-container {
position: relative;
width: 100%;
height: 0;
padding-bottom: 70%;
}

& .image {
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
width: 100%;
height: 100%;
}
`}
`;

/** .image className */
export const Image = styled.div<ImageProps>`
height: 110px;
height: 110px; // display === 'carousel';
border-radius: 5px;
${({ image }) => css`
background:
Expand All @@ -28,6 +66,7 @@ export const InfoContainer = styled.div`
flex-direction: column;
align-items: flex-start;
gap: 2px;
margin-top: 8px;
`;

export const Title = styled.div`
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import styled from "@emotion/styled";

export const GridAnimeCardSkeletonContainer = styled.div`
width: calc(50% - 4px);
&:nth-of-type(odd) {
margin-right: 8px;
}

${({ theme }) => theme.mq("sm")} {
width: calc(33% - 4px);
&:nth-of-type(odd) {
margin-right: 0;
}
&:not(:nth-of-type(3n)) {
margin-right: 8px;
}
}
`;
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { GridAnimeCardSkeletonContainer } from "./GridAnimeCardSkeleton.style";

import AnimeCardSkeleton from ".";

export default function GridAnimeCardSkeleton() {
return (
<GridAnimeCardSkeletonContainer>
<AnimeCardSkeleton />
</GridAnimeCardSkeletonContainer>
);
}
6 changes: 3 additions & 3 deletions src/features/animes/components/AnimeCardSkeleton/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { AnimeCardSkeletonContainer } from "./style";
export default function AnimeCardSkeleton() {
return (
<AnimeCardSkeletonContainer aria-busy="true">
<Skeleton w={160} h={110} />
<Skeleton w={130} h={22} />
<Skeleton w={40} h={22} />
<Skeleton w={"full"} h={110} />
<Skeleton w={60} h={22} wUnit="%" />
<Skeleton w={30} h={22} wUnit="%" />
</AnimeCardSkeletonContainer>
);
}
1 change: 1 addition & 0 deletions src/features/animes/components/AnimeCardSkeleton/style.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import styled from "@emotion/styled";

export const AnimeCardSkeletonContainer = styled.div`
width: 100%;
display: flex;
flex-direction: column;
gap: 8px;
Expand Down
1 change: 1 addition & 0 deletions src/features/animes/components/AnimeMainCarousel/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export const AnimeMainCarouselContainer = styled.div<{ image: string }>`
width: 100%;
height: 545px;
overflow: hidden;
cursor: pointer;

${({ theme }) => theme.mq("md")} {
& .slick-prev,
Expand Down
4 changes: 3 additions & 1 deletion src/features/animes/components/AnimeRanking/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const AnimeRankingContainer = styled.section`

/* 아래쪽 캐러셀의 왼쪽 마진 */
& .slick-slider:last-child {
& .slick-track .slick-slide:first-child {
& .slick-track .slick-slide:first-of-type {
margin-left: 16px;
}
}
Expand Down Expand Up @@ -98,6 +98,7 @@ export const HighlightItemContainer = styled.div`
padding-bottom: 46%;
margin: 0 auto;
margin-bottom: 4px;
cursor: pointer;
`;

export const HighlightItem = styled.div<ItemProps>`
Expand Down Expand Up @@ -144,6 +145,7 @@ export const SliderItem = styled.div`
flex-direction: column;
gap: 8px;
flex-shrink: 0;
cursor: pointer;

& > div:last-of-type {
${({ theme }) => theme.typo["body-3-r"]}
Expand Down
1 change: 1 addition & 0 deletions src/features/animes/components/AnimeSlide/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export default function AnimeSlide({ title, animes }: AnimeSlideProps) {
{animes.map((anime) => (
<AnimeCard
key={anime.id}
display="carousel"
id={anime.id}
thumbnail={anime.thumbnail}
title={anime.title}
Expand Down
2 changes: 1 addition & 1 deletion src/features/animes/components/AnimeSlide/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const AnimeSlideContainer = styled.section`

/* 캐러셀 왼쪽 마진 */
& .slick-slider {
& .slick-track .slick-slide:first-child {
& .slick-track .slick-slide:first-of-type {
margin-left: 16px;
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/features/animes/routes/Detail/LoadingReviews/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import styled from "@emotion/styled";
export const ReviewSkeleton = styled.li`
padding: 16px 10px 20px;

& > div:nth-child(2) {
& > div:nth-of-type(2) {
margin: 8px 0 4px;
}

& > div:nth-child(3) {
& > div:nth-of-type(3) {
margin-bottom: 6px;
}

Expand Down
31 changes: 9 additions & 22 deletions src/features/animes/routes/List/index.tsx
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@
import { SlidersHorizontal } from "@phosphor-icons/react";
import { useRef } from "react";
import { useNavigate } from "react-router";
import { v4 as uuid } from "uuid";

import Button from "@/components/Button";
import Empty from "@/components/Error/Empty";
import Head from "@/components/Head";
import Header from "@/components/Layout/Header";
import Skeleton from "@/components/Skeleton";
import { TabItem } from "@/components/Tabs";
import AnimeCard from "@/features/animes/components/AnimeCard";
import useIntersectionObserver from "@/hooks/useIntersectionObserver";

import { AnimeSort } from "../../api/AnimeApi";
import GridAnimeCardSkeleton from "../../components/AnimeCardSkeleton/GridAnimeCardSkeleton";
import useFilterAnimes from "../../hooks/useFilterAnimes";

import Filter from "./Filter";
import {
AnimeListContainer,
Tabs,
Content,
AnimeSkeletonContainer,
} from "./style";
import { AnimeListContainer, Tabs, Content } from "./style";

const TabItems: TabItem[] = [
{
Expand Down Expand Up @@ -90,12 +84,8 @@ export default function AnimeList() {
/>
<Content>
{(animesQuery.isLoading || animesQuery.isFetching) &&
Array.from({ length: 7 }, () => (
<AnimeSkeletonContainer aria-busy="true" key={uuid()}>
<Skeleton w="full" h={152} />
<Skeleton w={120} h={24} />
<Skeleton w={30} h={24} />
</AnimeSkeletonContainer>
Array.from({ length: 7 }, (_, i) => (
<GridAnimeCardSkeleton key={i} />
))}

{!animesQuery.isLoading &&
Expand All @@ -107,14 +97,11 @@ export default function AnimeList() {
{!animesQuery.isLoading && !animesQuery.isFetching && (
<>
{animesQuery.data?.pages.map((item) => (
<>
<AnimeCard
{...item}
key={item.id}
onClick={() => navigate(`/animes/${item.id}`)}
/>
<span>{item.id}</span>
</>
<AnimeCard
{...item}
key={item.id}
onClick={() => navigate(`/animes/${item.id}`)}
/>
))}
<div ref={observeRef}></div>
</>
Expand Down
10 changes: 2 additions & 8 deletions src/features/animes/routes/List/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@ export const Tabs = styled(BaseTabs)`
export const Content = styled.div`
width: 100%;
display: flex;
flex-direction: column;
gap: 32px;
gap: 32px 0px;
flex-wrap: wrap;
padding: 24px 16px;
`;

export const AnimeSkeletonContainer = styled.div`
display: flex;
flex-direction: column;
gap: 8px;
`;
30 changes: 12 additions & 18 deletions src/features/animes/routes/Search/SearchedAnimes/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Empty from "@/components/Error/Empty";
import AnimeCard, {
AnimeCardProps,
} from "@/features/animes/components/AnimeCard";
import AnimeCardSkeleton from "@/features/animes/components/AnimeCardSkeleton";
import GridAnimeCardSkeleton from "@/features/animes/components/AnimeCardSkeleton/GridAnimeCardSkeleton";
import useIntersectionObserver from "@/hooks/useIntersectionObserver";

import { SearchedAnimesContainer } from "./style";
Expand Down Expand Up @@ -41,14 +41,9 @@ export default function SearchedAnimes({
return (
<SearchedAnimesContainer>
<DeferredComponent>
<AnimeCardSkeleton />
<AnimeCardSkeleton />
<AnimeCardSkeleton />
<AnimeCardSkeleton />
<AnimeCardSkeleton />
<AnimeCardSkeleton />
<AnimeCardSkeleton />
<AnimeCardSkeleton />
{Array.from({ length: 4 }, (_, i) => (
<GridAnimeCardSkeleton key={i} />
))}
</DeferredComponent>
</SearchedAnimesContainer>
);
Expand All @@ -65,15 +60,14 @@ export default function SearchedAnimes({
return (
<SearchedAnimesContainer>
{animes.map((anime) => (
<li key={anime.id}>
<AnimeCard
id={anime.id}
thumbnail={anime.thumbnail}
title={anime.title}
starScoreAvg={anime.starScoreAvg}
onClick={() => navigate(`/animes/${anime.id}`)}
/>
</li>
<AnimeCard
id={anime.id}
key={anime.id}
thumbnail={anime.thumbnail}
title={anime.title}
starScoreAvg={anime.starScoreAvg}
onClick={() => navigate(`/animes/${anime.id}`)}
/>
))}
<div ref={observeRef}></div>
</SearchedAnimesContainer>
Expand Down
2 changes: 1 addition & 1 deletion src/features/animes/routes/Search/SearchedAnimes/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ import styled from "@emotion/styled";

export const SearchedAnimesContainer = styled.ul`
display: flex;
gap: 32px 8px;
gap: 32px 0;
flex-wrap: wrap;
`;
Loading