Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review 1b for RFC-2 #254

Merged
merged 4 commits into from
Aug 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions rfc/2/review_1b.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Updated Review of RFC-2: Zarr v3

## Review authors
This review was written by the following Glencoe Software team members:

- Sebastién Besson
melissalinkert marked this conversation as resolved.
Show resolved Hide resolved
- Melissa Linkert

## Summary

The changes to RFC-2 in https://github.com/ome/ngff/pull/250 are sufficient to update our recommendation from "Major changes" to "Accept".

Our original [Concern #1](https://ngff.openmicroscopy.org/rfc/2/review_1.html#concern-1-limited-zarr-v3-implementations) is addressed by the addition of references to zarr-python and zarr-java, as well as [clarifications to the zarr-java API](https://github.com/zarr-developers/zarr-java/issues/5) prompted by work on [v2/v3 conversion tools](https://github.com/glencoesoftware/zarr2zarr). Remaining concerns in [our original review](https://ngff.openmicroscopy.org/rfc/2/review_1.html) are addressed by stronger language around how applications should handle multiple versions and the usage of ‘ome’ as the top-level key for the OME-NGFF metadata in zarr.json.

## Recommendation

Our recommendation is "Accept". Additionally, as the maintainers of the [bioformats2raw](https://github.com/glencoesoftware/bioformats2raw) and [raw2ometiff](https://github.com/glencoesoftware/raw2ometiff), we plan to implement Zarr v3 support in these libraries by the end of 2024.
Loading