Add review 1b for RFC-2 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated Review URLs |
sbesson
reviewed
Aug 12, 2024
Co-authored-by: Sébastien Besson <[email protected]>
|
Thanks, Team Glencoe. Merging. |
github-actions bot
added a commit
that referenced
this pull request
Aug 26, 2024
…ew1b Add review 1b for RFC-2 SHA: 6caf3a8 Reason: push, by @joshmoore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On behalf of the @glencoesoftware team (in particular @sbesson and myself), this adds an updated review for RFC-2 based on #250.
As @joshmoore suggested separately, the updated review is in a separate file
review_1b.md, where the original review was inreview_1.md.