Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Bio-Formats 8.0.0 #757

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Updates for Bio-Formats 8.0.0 #757

merged 6 commits into from
Oct 24, 2024

Conversation

melissalinkert
Copy link
Member

Preparation for tomorrow's planned release. See also ome/bio-formats-documentation#397.

@sbesson
Copy link
Member

sbesson commented Oct 24, 2024

@jburel this PR is now effectively to be reviewed and published by the OME team.
Note the CI build is failing on 2 types of links:

@jburel
Copy link
Member

jburel commented Oct 24, 2024

@jburel this PR is now effectively to be reviewed and published by the OME team. Note the CI build is failing on 2 types of links:

  • https://docs.openmicroscopy.org/bio-formats/8.0.0/ and its sub-pages. The documentation has been officially published on readthedocs but as I understand as a result of the migration of the docs.openmicroscopy.org service, the strategy needs to be modified

What strategy are you refereeing to?
The .htacess with the redirect has been in place for now several releases and was used by Apache
We now have a script that will update the nginx config.
Are you thinking of something else?

I don't think that this is due to the migration. Not something I was aware of

@sbesson
Copy link
Member

sbesson commented Oct 24, 2024

What strategy are you refereeing to?
The .htacess with the redirect has been in place for now several releases and was used by Apache
We now have a script that will update the nginx config.
Are you thinking of something else?

I have no specifics other than the URL above was not functional immediately after tagging bio-formats-documentation. If you fixed the issue with another script updating the NGINX configuration, that's great.

I don't think that this is due to the migration. Not something I was aware of

There is no relationship with the migration but this failure is holding the review of this PR by the OME team (and its deployment eventually). Should we add it the exclude list in

docker run --rm -v $(pwd)/_site:/site jekyll/builder:pages /usr/gem/bin/htmlproofer /site --only_4xx --ignore-status-codes "429" --ignore-files "/site/minutes/,/minutes/,/site/2014/,/site/2018/,/site/citing-ome/,/site/teams/,/site/about/" --ignore-urls "/www.icr.ac.uk/,/medium.com/pangeo/,/java.com/en/download/help/java_6.html/,/columbia.edu/,/eurobioimaging.eu/,/github.com/openmicroscopy/openmicroscopy/commit/,/icm-institute.org/wp-content/,/figure.openmicroscopy.org/demo/,/loci.wisc.edu/,/twitter.com/,/biovisioncenter.uzh.ch/,/www.dundee.ac.uk/locations/national-phenotypic-screening-centre-npsc/,/monash.edu/,/micronoxford.com/,/upf.edu/,/scientifica.uk.com/,/uk1s3.embassy.ebi.ac.uk/,/biorxiv.org/,/openmicroscopy.org/events/ome-community-meeting-2024/,/meded.hms.harvard.edu/,/loc.gov/,/royalsocietypublishing.org/,/science.1082602/,/www.softwarecollections.org/" --no-enforce-https --allow-missing-href --typhoeus='{"headers" : {"User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Brave Chrome/91.0.4472.164 Safari/537.36"}}'
and let you guys review as a follow-up?

@jburel
Copy link
Member

jburel commented Oct 24, 2024

It was never available after tagging. The job runs every hour

@hourly (cd /uod/idr/scratch/management_tools/bin && bash release_combine.sh)

The new job was not part of cron job since I finished it this morning.
If we want to run more frequently we can
Downloads was updated almost immediately since the tag was pushed before the top of the hour.

@jburel
Copy link
Member

jburel commented Oct 24, 2024

https://sourceforge.net/p/icu/mailman/message/35232691/ is also failing.I just noticed that it failed on a previous PR (minute)

Co-authored-by: jean-marie burel <[email protected]>
@jburel jburel merged commit 44415a4 into ome:master Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants