Add functions to check availablility of CBOR tag numbers #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * Adds IsCBORTagNumberRangeAvailable() * Adds ReservedCBORTagNumberRange() * Reserves CBOR tag numbers [240, 255] for atree internal use IsCBORTagNumberRangeAvailable() checks if specified range of CBOR tag numbers can be used to encode elements managed by atree containers. ReservedCBORTagNumberRange() returns minTagNum and maxTagNum of the range of CBOR tag numbers reserved by atree. Currently, Atree and Cadence uses CBOR tag numbers: * Atree: 246 to 255 * Cadence: 128 to 230 to encode internal Cadence values This commit reserves CBOR tag numbers [240, 255] for atree internal use. Applications must use unreserved CBOR tag numbers to encode elements managed by atree containers. When a new tag number is needed, Atree will use higher tag number first from its reserved range. By contrast, Cadence will use lower tag numbers first from its own (different) reserved range. This allows Atree and Cadence more flexibility in case we need to revisit the allocation of adjacent unused ranges for Atree and Cadence.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
IsCBORTagNumberRangeAvailable()ReservedCBORTagNumberRange()IsCBORTagNumberRangeAvailable()checks if specified range of CBOR tag numbers can be used to encode elements managed by atree containers.ReservedCBORTagNumberRange()returns minTagNum and maxTagNum of the range of CBOR tag numbers reserved by atree.Currently, Atree and Cadence uses CBOR tag numbers:
This PR reserves CBOR tag numbers [240, 255] for atree internal use. Applications must use unreserved CBOR tag numbers to encode elements managed by atree containers.
When a new tag number is needed, Atree will use higher tag number first from its reserved range. By contrast, Cadence will use lower tag numbers first from its own (different) reserved range. This allows Atree and Cadence more flexibility in case we need to revisit the allocation of adjacent unused ranges for Atree and Cadence.
mainbranchFiles changedin the Github PR explorer