Delegate Cadence composite Storable() to Atree
#2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Cadence ArrayValue, CompositeValue, and DictionaryValue creates atree.Storable directly from StorageID of its Atree values. In the future, some Atree values can be inlined so they don't have StorageID, and Atree values need to handle Storable depending on maxInlineSize and other factors. This commit delegates Cadence composite values' Storable() to its internal Atree values. So future changes to Atree values and their storables don't break Cadence.
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 5f84e78 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2621 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 336 336
Lines 77869 77869
=======================================
Hits 61207 61207
Misses 14379 14379
Partials 2283 2283
Flags with carried forward coverage won't be shown. Click here to find out more.
|
turbolent
approved these changes
Jul 5, 2023
fxamacker
deleted the
fxamacker/delegate-cadence-composite-storable-to-atree
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates onflow/atree#292
Description
Currently, Cadence
ArrayValue,CompositeValue, andDictionaryValuecreatesatree.Storabledirectly fromStorageIDof its Atree values.In the future, some Atree values can be inlined so they don't have
StorageID, and Atree values need to handleStorabledepending onmaxInlineSizeand other factors.This PR delegates Cadence composite values'
Storable()to its internal Atree values. So future changes to Atree values and their storables won't break Cadence.masterbranchFiles changedin the Github PR explorer