Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainnet prep #111

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Mainnet prep #111

merged 5 commits into from
Aug 31, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Aug 28, 2024

Closes: #108

Description

  • Adds Mainnet account to flow.json & README, removing Previewnet
  • Adds Mainnet template contracts & configuration JSON-Cadence args
  • Updates the deployment script to prevent USDCFlow TokenHandler configuration

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Aug 28, 2024
@sisyphusSmiling sisyphusSmiling added Documentation Improvements or additions to documentation Deployment Requires contract deployment or update labels Aug 28, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review August 28, 2024 01:48
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner August 28, 2024 01:48
@sisyphusSmiling sisyphusSmiling requested a review from nvdtf August 28, 2024 01:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (a9d52f9) to head (ab4de5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          17       17           
  Lines         922      922           
=======================================
  Hits          796      796           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

usdcFlowAddr := o.Address("USDCFlow")
usdcFlowVaultIdentifier := buildUSDCFlowVaultIdentifier(usdcFlowAddr)
usdcFlowMinterIdentifier := buildUSDCFlowMinterIdentifier(usdcFlowAddr)
// usdcFlowAddr := o.Address("USDCFlow")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out? Is this because we had to leave out the bridge related stuff in USDCFlow because it didn't migrate properly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, since USDCFlow won't be migrated with bridge dependencies, we won't be able to configure a CadenceNativeTokenHandler for in the process of deploying the bridge contracts. We'll still be able to configure it before activating the bridge, it will just need to be done outside of the context of this script.

@sisyphusSmiling sisyphusSmiling merged commit f7c98ea into main Aug 31, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the mainnet-prep branch August 31, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Requires contract deployment or update Documentation Improvements or additions to documentation
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Prepare a Mainnet account & deploy 0.42 dependency contracts
3 participants