-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mainnet prep #111
Mainnet prep #111
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 17 17
Lines 922 922
=======================================
Hits 796 796
Misses 126 126 ☔ View full report in Codecov by Sentry. |
usdcFlowAddr := o.Address("USDCFlow") | ||
usdcFlowVaultIdentifier := buildUSDCFlowVaultIdentifier(usdcFlowAddr) | ||
usdcFlowMinterIdentifier := buildUSDCFlowMinterIdentifier(usdcFlowAddr) | ||
// usdcFlowAddr := o.Address("USDCFlow") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out? Is this because we had to leave out the bridge related stuff in USDCFlow because it didn't migrate properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, since USDCFlow won't be migrated with bridge dependencies, we won't be able to configure a CadenceNativeTokenHandler
for in the process of deploying the bridge contracts. We'll still be able to configure it before activating the bridge, it will just need to be done outside of the context of this script.
Closes: #108
Description
For contributor use:
main
branchFiles changed
in the Github PR explorer