added display-type to generated serialized json for attributes #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .concat(", \"value\": ").concat(value!) | ||
| .concat("}") | ||
| .concat("\"trait_type\": ").concat(Serialize.tryToJSONString(trait.name)!) | ||
| .concat(", \"display_type\": ").concat(Serialize.tryToJSONString(trait.display_type)!) |
There was a problem hiding this comment.
Since this value is optional in both Cadence and in OpenSea's standard, I'm wondering if we should conditionally include this here. Otherwise the serialized field may contain nil values for a field that is listed as optionally included.
Suggested change
| .concat(", \"display_type\": ").concat(Serialize.tryToJSONString(trait.display_type)!) | |
| .concat(", \"display_type\": ").concat(Serialize.tryToJSONString(trait.displayType)!) |
sisyphusSmiling
requested changes
Oct 17, 2024
|
That is probably wise yes |
|
@bjartek in the interest of moving the PR along and make the suggested changes, I'll update to target a feature branch and pick up the PR |
sisyphusSmiling
merged commit a5630a7
into
onflow:gio/update_display_type
1 of 2 checks passed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The generated json does not include display_type
Sorry for whitespace mod here. lmk if you want me to redo.