Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update args json #54

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Update args json #54

merged 3 commits into from
Apr 26, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Apr 26, 2024

Closes: #53


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Apr 26, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 26, 2024 21:31
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner April 26, 2024 21:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (428634e) to head (2164a0e).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   82.88%   85.56%   +2.67%     
==========================================
  Files          18       19       +1     
  Lines         818      859      +41     
==========================================
+ Hits          678      735      +57     
+ Misses        140      124      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit 6cc0530 into main Apr 26, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the update-args-json branch April 26, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update code template args json
3 participants