Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant normalization step from CI #58

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Apr 30, 2024

Description

This normalization is now embedded in the 'flow test' command.

For example, running:

flow test --cover --covercode="contracts" --coverprofile="coverage.lcov" cadence/tests/flow_evm_bridge_handler_tests.cdc

And viewing the coverage.lcov file:

TN:
SF:./cadence/contracts/utils/EVMUtils.cdc
DA:15,35
DA:18,35
...
LF:9
LH:7
end_of_record
TN:
SF:./cadence/contracts/bridge/FlowEVMBridge.cdc
DA:72,1
DA:73,1

We can see that the SF property contains the correct file path.


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

This normalization is now embedded in the 'flow test' command.
@m-Peter m-Peter self-assigned this Apr 30, 2024
@m-Peter m-Peter requested a review from a team as a code owner April 30, 2024 09:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (428634e) to head (51f0440).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   82.88%   85.56%   +2.67%     
==========================================
  Files          18       19       +1     
  Lines         818      859      +41     
==========================================
+ Hits          678      735      +57     
+ Misses        140      124      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-Peter m-Peter requested a review from sisyphusSmiling April 30, 2024 12:39
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sisyphusSmiling sisyphusSmiling merged commit 8d023e1 into main Apr 30, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the remove-redundant-normalization-step-from-ci branch April 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants