-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs to merge #5484
Add logs to merge #5484
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5484 +/- ##
==========================================================
- Coverage 56.21% 56.10% -0.12%
==========================================================
Files 1039 986 -53
Lines 101283 96847 -4436
==========================================================
- Hits 56940 54337 -2603
+ Misses 40028 38323 -1705
+ Partials 4315 4187 -128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
// we expect more than one address to change here | ||
flow.EmptyAddress, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be a parameter. In NewDeploymentMigration
, the value can be authorizer
, i.e. where the contract is deployed to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transactions will change more than just the authoriser account.
They might also change the global uuid counter.
Nice! Thanks for adding this. Merging this into the WIP #5479 |
Add extra logs to the merge function.
When doing account based migration only that one account should have changes.