Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs to merge #5484

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Feb 29, 2024

Add extra logs to the merge function.

When doing account based migration only that one account should have changes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 56.10%. Comparing base (c41bc8a) to head (1fc2d25).
Report is 3 commits behind head on feature/stable-cadence.

Files Patch % Lines
cmd/util/ledger/migrations/merge.go 28.00% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5484      +/-   ##
==========================================================
- Coverage                   56.21%   56.10%   -0.12%     
==========================================================
  Files                        1039      986      -53     
  Lines                      101283    96847    -4436     
==========================================================
- Hits                        56940    54337    -2603     
+ Misses                      40028    38323    -1705     
+ Partials                     4315     4187     -128     
Flag Coverage Δ
unittests 56.10% <35.71%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +56 to +57
// we expect more than one address to change here
flow.EmptyAddress,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be a parameter. In NewDeploymentMigration, the value can be authorizer, i.e. where the contract is deployed to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transactions will change more than just the authoriser account.
They might also change the global uuid counter.

@turbolent turbolent changed the base branch from feature/stable-cadence to bastian/improve-migration-2 February 29, 2024 19:39
@turbolent
Copy link
Member

Nice! Thanks for adding this. Merging this into the WIP #5479

@turbolent turbolent merged commit cf232f0 into bastian/improve-migration-2 Feb 29, 2024
@turbolent turbolent deleted the janez/add-logs-to-merge branch February 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants